amd64: macroify copyinstr
AbandonedPublic
Actions

Authored by mjg on Sep 22 2018, 11:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 15, 2:32 PM

	Unknown Object (File)
	Thu, Oct 30, 1:22 AM

	Unknown Object (File)
	Wed, Oct 29, 12:32 PM

	Unknown Object (File)
	Wed, Oct 29, 12:32 PM

	Unknown Object (File)
	Wed, Oct 29, 6:26 AM

	Unknown Object (File)
	Sun, Oct 26, 7:09 AM

	Unknown Object (File)
	Oct 12 2025, 2:11 AM

	Unknown Object (File)
	Oct 1 2025, 1:06 PM

View All 48 Files

Subscribers

imp

Details

Reviewers

kib

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 19752

Event Timeline

mjg created this revision.Sep 22 2018, 11:48 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 22 2018, 11:48 AM

Harbormaster completed remote builds in B19752: Diff 48351.Sep 22 2018, 11:48 AM

mjg added a child revision: D17288: amd64: depessimize copyinstr.Sep 22 2018, 11:51 AM

kib added inline comments.Sep 22 2018, 4:50 PM

sys/amd64/amd64/support.S
974	Why do you need a second copy of this prologue ?

mjg marked an inline comment as done.Sep 23 2018, 2:54 PM

mjg added inline comments.

sys/amd64/amd64/support.S
974	I would have to add a special case to the macro so that one primitive gets a label this can jump to. i can do that, but I think it would be uglier. Later I want to move all fault handling to the end of the file.

went in as part of r338970

Revision Contents
Changeset List

Path

Size

sys/

amd64/

support.S

73 lines

Diff 48351

View Options

amd64: macroify copyinstrAbandonedPublicActions