In 11.x and earlier these were accessible as direct members of
'struct kinfo_file'. This adds wrapper macros to restore that API
similar to those used for kf_sock_domain and some other fields.
Details
Details
- Reviewers
kib - Commits
- rS338916: Restore the API of the kf_sa_local and kf_sa_peer members.
- buildworld and buildkernel
- noticed because my very recent changes to gdb to add 'info proc files' failed to build on head
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19711 Build 19274: arc lint + arc unit
Event Timeline
| sys/sys/user.h | ||
|---|---|---|
| 354 | Then rename it to kf_sock_local0 ? | |
| sys/sys/user.h | ||
|---|---|---|
| 354 | Hmm, in that case I can drop the 0 and just use kf_sock_local. | |
Comment Actions
when modifying calls to bcopy with non-verlapping stores, please change them to memcpy
Comment Actions
- Use an anonymous union and struct for FreeBSD 11 compat fields.
- Rename the kf_un.kf_sock variants back to their original names.
Comment Actions
So the fact that some things were updated for the new name and that it clashed with the old name made just reverting to the old name messy. I already had done the union change as a followup to remove the compat macros, and it occurred to me that since I had it, I could actually go back to using kf_sa_local/peer in both places which would let both the old and new names work at the same time. This in theory shouldn't require reverting any of the ports changes or upstream port changes while still preserving the existing API. We could even go back and fix the kf_sock_ variants to remove the trailing '0' now if we wished to as well.