Page MenuHomeFreeBSD
Differential D17253

vfs: remove lookup_shared tunable
ClosedPublic
Actions

Authored by mjg on Sep 20 2018, 6:38 AM.
Tags
None
Referenced Files
F166613356: D17253.id48251.diff
Fri, Aug 14, 9:16 PM
Unknown Object (File)
Thu, Aug 13, 4:23 PM
Unknown Object (File)
Thu, Aug 13, 2:38 PM
Unknown Object (File)
Wed, Aug 12, 12:25 PM
Unknown Object (File)
Wed, Aug 12, 6:12 AM
Unknown Object (File)
Mon, Aug 10, 9:56 PM
Unknown Object (File)
Mon, Aug 10, 1:48 PM
Unknown Object (File)
Mon, Aug 10, 7:49 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
jhb
Commits
rS338835: vfs: remove lookup_shared tunable

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19690
Build 19255: arc lint + arc unit

Event Timeline

mjg created this revision.Sep 20 2018, 6:38 AM
Harbormaster completed remote builds in B19690: Diff 48251.Sep 20 2018, 6:38 AM
kib accepted this revision.Sep 20 2018, 10:21 AM
kib added a reviewer: jhb.

Why ?

This revision is now accepted and ready to land.Sep 20 2018, 10:21 AM
mjg added a comment.Sep 20 2018, 10:34 AM

I want to annotate globals used during typical vfs ops (__read_mostly, pad locally or whatever else). I highly doubt this var is of any real-world use today, so I would like to see it gone.

jhb accepted this revision.Sep 20 2018, 4:15 PM

Originally it was useful to disable this when a bug was encountered, but the window where that was useful probably ended several years ago.

Closed by commit rS338835: vfs: remove lookup_shared tunable (authored by mjg). · Explain WhySep 20 2018, 6:25 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptSep 20 2018, 6:25 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
13 lines

Diff 48251

View Options

sys/kern/vfs_lookup.c

Loading...