ClosedPublic
Actions

Authored by brd on Sep 18 2018, 8:59 PM.

Details

Reviewers

bapt
will

Commits

rS338794: Move regdomain.xml to lib/lib80211/

Test Plan

Test by comparing the results of make distribution

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19654
Build 19224: arc lint + arc unit

Event Timeline

brd created this revision.Sep 18 2018, 8:59 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 18 2018, 8:59 PM

Harbormaster completed remote builds in B19654: Diff 48191.Sep 18 2018, 8:59 PM

will requested changes to this revision.Sep 18 2018, 10:15 PM

will added inline comments.

sbin/ifconfig/Makefile
6	The original file has a MK_WIRELESS requirement, but sbin/ifconfig does not. This file is actually referenced by `lib/lib80211` instead, why not move there?

This revision now requires changes to proceed.Sep 18 2018, 10:15 PM

FWIW, since lib80211 does not have an MK_WIRELESS exclusion, I don't think it makes sense to require it, but I do think it makes sense to ship with that library instead of ifconfig.

Move to lib80211

Harbormaster completed remote builds in B19661: Diff 48198.Sep 19 2018, 2:30 AM

will accepted this revision.Sep 19 2018, 2:39 AM

This revision is now accepted and ready to land.Sep 19 2018, 2:39 AM

Closed by commit rS338794: Move regdomain.xml to lib/lib80211/ (authored by brd). · Explain WhySep 19 2018, 9:29 AM

This revision was automatically updated to reflect the committed changes.