Page MenuHomeFreeBSD

multimedia/libdv: add -znotext to LDFLAGS on i386, for lld
ClosedPublic

Authored by emaste on Sep 18 2018, 1:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 7, 11:21 PM
Unknown Object (File)
Wed, Feb 26, 12:06 AM
Unknown Object (File)
Sun, Feb 23, 9:57 PM
Unknown Object (File)
Sat, Feb 15, 8:05 PM
Unknown Object (File)
Sat, Feb 15, 8:05 PM
Unknown Object (File)
Sat, Feb 15, 8:01 PM
Unknown Object (File)
Feb 10 2025, 5:35 PM
Unknown Object (File)
Feb 1 2025, 9:31 PM
Subscribers
None

Details

Summary

Example error:

/usr/bin/ld: error: can't create dynamic relocation R_386_32 against symbol: dv_vlc_class_index_mask in readonly segment; recompile object files with -fPIC
>>> defined in .libs/vlc.o
>>> referenced by .libs/vlc_x86.o:(.text+0xF)

This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 2:53 PM
This revision was automatically updated to reflect the committed changes.