Page MenuHomeFreeBSD

multimedia/libdv: add -znotext to LDFLAGS on i386, for lld
ClosedPublic

Authored by emaste on Sep 18 2018, 1:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 1:22 PM
Unknown Object (File)
Sat, Apr 20, 11:34 AM
Unknown Object (File)
Sat, Apr 20, 11:34 AM
Unknown Object (File)
Sat, Apr 20, 11:34 AM
Unknown Object (File)
Sat, Apr 20, 11:21 AM
Unknown Object (File)
Sat, Apr 20, 1:30 AM
Unknown Object (File)
Mon, Apr 15, 6:11 AM
Unknown Object (File)
Mon, Apr 15, 6:06 AM
Subscribers
None

Details

Summary

Example error:

/usr/bin/ld: error: can't create dynamic relocation R_386_32 against symbol: dv_vlc_class_index_mask in readonly segment; recompile object files with -fPIC
>>> defined in .libs/vlc.o
>>> referenced by .libs/vlc_x86.o:(.text+0xF)

This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 2:53 PM
This revision was automatically updated to reflect the committed changes.