Page MenuHomeFreeBSD
Differential D17220

multimedia/libdv: add -znotext to LDFLAGS on i386, for lld
ClosedPublic
Actions

Authored by emaste on Sep 18 2018, 1:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 5:27 AM
Unknown Object (File)
Sat, Apr 27, 3:41 PM
Unknown Object (File)
Sat, Apr 20, 1:22 PM
Unknown Object (File)
Sat, Apr 20, 11:34 AM
Unknown Object (File)
Sat, Apr 20, 11:34 AM
Unknown Object (File)
Sat, Apr 20, 11:34 AM
Unknown Object (File)
Sat, Apr 20, 11:21 AM
Unknown Object (File)
Sat, Apr 20, 1:30 AM
View All 68 Files
Subscribers
None

Details

Reviewers
None
Group Reviewers
Ports Committers
Commits
rP480028: multimedia/libdv: add -znotext to LDFLAGS on i386, for lld
Summary

Example error:

/usr/bin/ld: error: can't create dynamic relocation R_386_32 against symbol: dv_vlc_class_index_mask in readonly segment; recompile object files with -fPIC
>>> defined in .libs/vlc.o
>>> referenced by .libs/vlc_x86.o:(.text+0xF)

This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Sep 18 2018, 1:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 2:53 PM
Closed by commit rP480028: multimedia/libdv: add -znotext to LDFLAGS on i386, for lld (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
multimedia/
libdv/
3 lines

Diff 48163

View Options

multimedia/libdv/Makefile

Loading...