multimedia/libx264: add -znotext to LDFLAGS on i386, for lld
ClosedPublic
Actions

Authored by emaste on Sep 17 2018, 3:12 PM.

Details

Reviewers

koobs

Commits

rP480024: multimedia/libx264: add -znotext to LDFLAGS on i386, for lld

Summary

Example error:

/usr/bin/ld: error: can't create dynamic relocation R_386_PC32 against symbol: gettimeofday in readonly segment; recompile object files with -fPIC

This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default.

Original version committed in rS479024, this review represents a preferred approach.

I am not a ports committer, so please explicitly mention approval for commit to the ports tree.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Sep 17 2018, 3:12 PM

ndowens_yahoo.com added inline comments.Sep 17 2018, 7:29 PM

multimedia/libx264/Makefile
17	Reverse line 17 and 18 so it’s declared before variable is used

The variable substitution/evaluation is done at the end so it works both ways; my natural tendency would be to put them in the other order but this was the one used in the first instance of this approach in review D16813 / rP478120 by @mmokhi.

Any change fixing this issue was (and is) explicitly approved (subject to @emaste confidence in solution/QA) per bugzilla issue comment: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230214#c7

This revision is now accepted and ready to land.Sep 18 2018, 3:02 AM

koobs added inline comments.Sep 18 2018, 3:05 AM

multimedia/libx264/Makefile
17	Does this need to be wrapped in a `if defined(${LDFLAGS_${ARCH}})` block to protect a failure if the variable is not defined for the ARCH the port is being built on?