Page MenuHomeFreeBSD
Differential D17187

Add warnings when _ON is defined and _OFF is not (and vice versa)
Needs ReviewPublic
Actions

Authored by mat on Sep 17 2018, 8:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 21 2024, 6:33 PM
Unknown Object (File)
Jan 5 2024, 5:40 PM
Unknown Object (File)
Dec 25 2023, 9:42 AM
Unknown Object (File)
Dec 24 2023, 4:44 AM
Unknown Object (File)
Nov 8 2023, 12:43 PM
Unknown Object (File)
Nov 6 2023, 6:55 PM
Unknown Object (File)
Oct 30 2023, 11:55 PM
Unknown Object (File)
Oct 18 2023, 6:51 AM
View All 15 Files
Subscribers
antoine
bapt

Details

Reviewers
None
Group Reviewers
portmgr

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19618
Build 19193: arc lint + arc unit

Event Timeline

mat created this revision.Sep 17 2018, 8:34 AM
Harbormaster completed remote builds in B19614: Diff 48094.Sep 17 2018, 8:34 AM
antoine added a subscriber: antoine.Sep 17 2018, 9:31 AM

I don't think it's right, there are legitimate use of _ON without _OFF.

bapt added a subscriber: bapt.Sep 17 2018, 9:33 AM

I do agree with @antoine

mat added a comment.Sep 17 2018, 9:55 AM

There are, yes, I agree, this is why it is a warning, not an error, something saying "hey, make sure you did not mess it up".

mat added a comment.Sep 17 2018, 11:35 AM

Or do we need to have a third level like, DEV_NOTICE, because people treat warnings as errors ?

mat updated this revision to Diff 48101.Sep 17 2018, 11:54 AM
  • Add warnings about OPTIONS_SLAVE and OPTIONS_EXCLUDE.
  • Add warnings about non existent options for specific variables.
Harbormaster completed remote builds in B19618: Diff 48101.Sep 17 2018, 11:54 AM

Revision Contents
Changeset List

PathSize
Mk/
52 lines

Diff 48101

View Options

Mk/bsd.options.mk

Loading...