Page MenuHomeFreeBSD
Differential D17155

graphics/partio: add DOXYGEN option
ClosedPublic
Actions

Authored by fernape on Sep 13 2018, 4:21 PM.
Tags
None
Referenced Files
F108268674: D17155.id48133.diff
Thu, Jan 23, 7:20 AM
F108268448: D17155.id48052.diff
Thu, Jan 23, 7:16 AM
F108265804: D17155.id48051.diff
Thu, Jan 23, 6:39 AM
Unknown Object (File)
Wed, Jan 8, 9:19 AM
Unknown Object (File)
Tue, Jan 7, 8:53 AM
Unknown Object (File)
Tue, Jan 7, 1:00 AM
Unknown Object (File)
Dec 21 2024, 4:40 PM
Unknown Object (File)
Dec 21 2024, 4:21 PM
View All 98 Files
Subscribers
mat

Details

Reviewers
tcberner
tz
Commits
rP480080: graphics/partio: Remove PYTHON option.
Summary

Most of the changes come from https://reviews.freebsd.org/D16662

  • Add DOXYGEN option.
  • Remove post-patch-PYTHON-off due to PYTHON_BROKEN_OFF
  • Move some variables to their proper locations
Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19571
Build 19156: arc lint + arc unit

Event Timeline

fernape created this revision.Sep 13 2018, 4:21 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 13 2018, 4:21 PM
Harbormaster completed remote builds in B19571: Diff 48009.Sep 13 2018, 4:21 PM
mat added inline comments.Sep 14 2018, 10:10 AM
graphics/partio/Makefile
14

Why move this?

38

Why move this?

fernape updated this revision to Diff 48051.Sep 14 2018, 1:52 PM

Keep USE_* sorted alphabetically

Harbormaster completed remote builds in B19596: Diff 48051.Sep 14 2018, 1:53 PM
fernape updated this revision to Diff 48052.Sep 14 2018, 1:54 PM

Keep related variables close

Harbormaster completed remote builds in B19597: Diff 48052.Sep 14 2018, 1:54 PM
fernape marked 2 inline comments as done.Sep 14 2018, 1:55 PM
mat added inline comments.Sep 14 2018, 4:42 PM
graphics/partio/Makefile
15

Why blank line?

29–31

Remove this maybe.

31–34

Maybe remove the option if it is required now.

fernape updated this revision to Diff 48133.Sep 17 2018, 5:04 PM
  • Remove blank line
  • Remove PYTHON option
Harbormaster completed remote builds in B19629: Diff 48133.Sep 17 2018, 5:04 PM
fernape marked 2 inline comments as done.Sep 17 2018, 5:05 PM
tcberner accepted this revision.Sep 18 2018, 7:02 PM

Looks good to me.

This revision is now accepted and ready to land.Sep 18 2018, 7:02 PM
Closed by commit rP480080: graphics/partio: Remove PYTHON option. (authored by fernape). · Explain WhySep 18 2018, 8:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
graphics/
partio/
25 lines

Diff 48009

View Options

graphics/partio/Makefile

Loading...