Differential D17124

ERMS-based memmove, memcpy and memset
ClosedPublic
Actions

Authored by mjg on Sep 11 2018, 11:15 PM.

Details

Reviewers

kib

Commits

rS338645: amd64: implement ERMS-based memmove, memcpy and memset

Summary

Tested with and without invariants.

I don't know where to put the resolving code, machdep.c seemed like the least objectionable place.

Note that memmove is kind of hairy and is up for further rework.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mjg created this revision.Sep 11 2018, 11:15 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 11 2018, 11:15 PM

Harbormaster completed remote builds in B19533: Diff 47932.Sep 11 2018, 11:15 PM

Please upload patch with context. svn diff -x -U99999

sys/amd64/amd64/support.S
1269	Move this right after _std. Also, I prefer to have each _erms variant to be located right after its _std counterpart.
1293	What is the purpose of the comment ?

remove the comment copied over from original memmove
include full-context diff

put erms funcs net to their standard counterparts

kib accepted this revision.Sep 13 2018, 2:35 PM

This revision is now accepted and ready to land.Sep 13 2018, 2:35 PM

Closed by commit rS338645: amd64: implement ERMS-based memmove, memcpy and memset (authored by mjg). · Explain WhySep 13 2018, 2:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

machdep.c

32 lines

support.S

62 lines

Diff 47997

View Options

sys/amd64/amd64/machdep.c