Page MenuHomeFreeBSD

ERMS-based memmove, memcpy and memset
ClosedPublic

Authored by mjg on Sep 11 2018, 11:15 PM.
Tags
None
Referenced Files
F99130244: D17124.diff
Sun, Oct 6, 4:43 PM
Unknown Object (File)
Thu, Oct 3, 12:16 AM
Unknown Object (File)
Fri, Sep 27, 1:20 AM
Unknown Object (File)
Tue, Sep 24, 9:14 AM
Unknown Object (File)
Wed, Sep 18, 7:22 PM
Unknown Object (File)
Tue, Sep 17, 9:59 AM
Unknown Object (File)
Wed, Sep 11, 6:29 AM
Unknown Object (File)
Wed, Sep 11, 6:25 AM
Subscribers

Details

Summary

Tested with and without invariants.

I don't know where to put the resolving code, machdep.c seemed like the least objectionable place.

Note that memmove is kind of hairy and is up for further rework.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Please upload patch with context. svn diff -x -U99999

sys/amd64/amd64/support.S
1269 ↗(On Diff #47932)

Move this right after _std. Also, I prefer to have each _erms variant to be located right after its _std counterpart.

1293 ↗(On Diff #47932)

What is the purpose of the comment ?

  • remove the comment copied over from original memmove
  • include full-context diff
  • put erms funcs net to their standard counterparts
This revision is now accepted and ready to land.Sep 13 2018, 2:35 PM
This revision was automatically updated to reflect the committed changes.