Page MenuHomeFreeBSD
Differential D17076

intelspi: don't leak spibus children on detach
ClosedPublic
Actions

Authored by yuripv on Sep 8 2018, 5:44 AM.
Tags
None
Referenced Files
F101322513: D17076.id47809.diff
Sun, Oct 27, 7:19 PM
F101317474: D17076.diff
Sun, Oct 27, 5:26 PM
Unknown Object (File)
Mon, Oct 14, 2:32 PM
Unknown Object (File)
Thu, Oct 3, 4:55 AM
Unknown Object (File)
Sep 25 2024, 7:58 AM
Unknown Object (File)
Sep 24 2024, 10:06 AM
Unknown Object (File)
Sep 24 2024, 6:50 AM
Unknown Object (File)
Sep 24 2024, 3:45 AM
View All 46 Files
Subscribers
imp
kib
Contributor Reviews (src)

Details

Reviewers
kib
Commits
rS338534: intelspi: don't leak spibus children on detach.
Test Plan
  1. kldload intelspi
  2. kldunload intelspi

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuripv created this revision.Sep 8 2018, 5:44 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptSep 8 2018, 5:44 AM
kib added a subscriber: kib.Sep 8 2018, 5:35 PM
kib added inline comments.
sys/dev/intel/spi.c
500 ↗(On Diff #47809)

There is device delete_children(9). It would be much more convenient to use there.

But I suspect that intelspi should be considered bus and then bus_generic_detach(9) used instead. See the call for bus generic_attach() above.

yuripv updated this revision to Diff 47816.Sep 8 2018, 5:41 PM

use bus_generic_detach().

yuripv marked an inline comment as done.Sep 8 2018, 5:42 PM
yuripv added inline comments.
sys/dev/intel/spi.c
500 ↗(On Diff #47809)

Even better, works the same.

yuripv marked an inline comment as done.Sep 8 2018, 5:43 PM
kib accepted this revision.Sep 8 2018, 5:52 PM
This revision is now accepted and ready to land.Sep 8 2018, 5:52 PM
Closed by commit rS338534: intelspi: don't leak spibus children on detach. (authored by kib). · Explain WhySep 8 2018, 6:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
intel/
2 lines

Diff 47817

View Options

head/sys/dev/intel/spi.c

Loading...