Page MenuHomeFreeBSD
Differential D17057

Don't define sctp probes unless the SCTP option is configured.
ClosedPublic
Actions

Authored by markj on Sep 6 2018, 2:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 16, 1:17 PM
Unknown Object (File)
Mon, May 27, 9:59 AM
Unknown Object (File)
May 9 2024, 8:53 PM
Unknown Object (File)
Apr 27 2024, 10:03 AM
Unknown Object (File)
Apr 27 2024, 10:02 AM
Unknown Object (File)
Apr 27 2024, 10:02 AM
Unknown Object (File)
Apr 27 2024, 8:33 AM
Unknown Object (File)
Dec 22 2023, 11:42 PM
View All 28 Files
Subscribers
imp

Details

Reviewers
tuexen
gnn
Commits
rS338496: Define sctp probes only when SCTP is configured.
Summary

Otherwise the "depends_on provider" guard in sctp.d doesn't work when
SCTP is omitted from the kernel config, and dtrace(1) fails to parse sctp.d
during startup since it references undefined types.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Sep 6 2018, 2:36 AM
markj edited the summary of this revision. (Show Details)Sep 6 2018, 2:37 AM
markj added a reviewer: tuexen.
Harbormaster completed remote builds in B19430: Diff 47717.Sep 6 2018, 12:25 PM
tuexen accepted this revision.Sep 6 2018, 1:10 PM

Thanks for the fix. I never tested on a system without SCTP support.

This revision is now accepted and ready to land.Sep 6 2018, 1:10 PM
Closed by commit rS338496: Define sctp probes only when SCTP is configured. (authored by markj). · Explain WhySep 6 2018, 2:15 PM
This revision was automatically updated to reflect the committed changes.
Herald added a reviewer: gnn. · View Herald TranscriptSep 6 2018, 2:15 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
6 lines

Diff 47752

View Options

head/sys/netinet/in_kdtrace.c

Loading...