Page MenuHomeFreeBSD

add pci support at rt1310
AbandonedPublic

Authored by yamori813_yahoo.co.jp on Aug 24 2018, 10:27 PM.
Tags
None
Referenced Files
F137439784: D16892.id.diff
Sun, Nov 23, 11:50 AM
Unknown Object (File)
Sat, Nov 22, 6:03 PM
Unknown Object (File)
Wed, Nov 19, 4:29 AM
Unknown Object (File)
Wed, Nov 12, 11:00 PM
Unknown Object (File)
Mon, Oct 27, 4:55 AM
Unknown Object (File)
Oct 19 2025, 9:56 AM
Unknown Object (File)
Oct 15 2025, 11:20 AM
Unknown Object (File)
Sep 24 2025, 2:52 AM
Subscribers

Details

Test Plan

WZR2-G300N

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19160
Build 18783: arc lint + arc unit

Event Timeline

Remove myself from blocking reviewer.

Herald doesn't like this ...
Consider it ok from me for dts changes.

Generally looks good. Please fix easy remarks.

sys/arm/ralink/rt1310_machdep.c
107

Why so big window? May be better to add additional entry?

sys/arm/ralink/rt1310_pci.c
256

Please move to beginning of function

274

Please split to 2 lines: declaration and assignment.

sys/arm/ralink/rt1310_machdep.c
127

This should be in a common header.

sys/arm/ralink/rt1310_pci.c
35

Is this needed?

237

What is this delay for?

239–243

What are these magic numbers?

244

And this delay. It's also held while we hold a mutex.

249–254

More magic numbers.