USES and USE_x block needs to move up to conform to Order of Variables in Port Makefiles in PH.

These belong in the The Rest of the Variables block according to the PH.

-f is already part of ${RM}

There is no rebar in the base system, so remove ${LOCALBASE}/bin/.

OPTIONS_DEFAULT should be first.

This should be post-patch.

No need for the / here.

Not sure why this change is needed, you have other occurrences of couchdb2 in the port, this one is no special.

done - but why is this better?

I think this qualifies under Keep related variables close together. For example, if using USE_GITHUB, always put the GH_* variables right after it.

I think this qualifies under Keep related variables close together. For example, if using USE_GITHUB, always put the GH_* variables right after it.

They are still not being stripped.
http://pkg.awarnach.mathstat.dal.ca/data/11amd64-default/2018-08-22_15h28m05s/logs/couchdb2-2.2.0.log

Maybe this?
@${FIND} -E ${STAGEDIR} -type f -regex '.+/(couchjs|.so)$$' -exec ${STRIP_CMD} {} \;

@${MKDIR}.... mkdir is an exception that can be silenced here.

Now I'm confused. Last diff I understood these all needed to be moved down to the bottom. Its awkward in phab to see where you want to move those back to - where would that end up? back below USES? Lets see if the next diff gets it right.

aaah I have STRIP= in my poudriere make.conf which is needed for dtrace support in erlang.. after wrapping that in a if .CURDIR.. endif I see these failures too during stage-qa, and my regex needs tweaking too. BTW is there a command to tell if a given binary hasn't been stripped (outside ports framework)?

shouldn-t docs be enabled by a DOCS option?

It has nothing to do with better, it is semantically wrong. You are patching the file, which should always happen in the patch phase.

The pre-configure target is in the configure phase, when you run commands to prepare the configuration, like re-generating a configure script, or whatever.

Wouldn't -name '*.so' be enough? Are there any other .so files in there that, for some reason should not be stripped?

Extra $ at the end?

My interpretation of Chapter 15 of the PH, and specifically Start this section with defining USES, and then possible USE_x. Keep related variables close together. For example, if using USE_GITHUB, always put the GH_* variables right after it. is

USES=          cpe gmake libtool ncurses python:run shebangfix
CPE_VENDOR=    apache
SHEBANG_FILES= rel/overlay/bin/couchup
USE_RC_SUBR=   couchdb2

but, to me, this is all small potatoes. @mat probably wrote that chapter, so maybe he can clarify.

Yeah, does not really matter. You can also add blank lines to let it breath a bit and be more readable.

No need for couchdb2 here.

Why +=?

Why +=?

Never use CP to install files, use one of the INSTALL_* macros.

I need to look a bit more into this, might be tomorrow. I'm not sure whether my current patch is actually doing what I expected it to.

Am I correct that running make DOCS= ... and make DOCS=1 ... is sufficient to test these options? Or is there a better way?

I'd expected that OTP*_RUN_DEPENDS will have the OTP*_ part stripped, and then needs to be appended to the existing RUN_DEPENDS from earlier in the Makefile that includes the py-requests?

It's going to WRKSRC, not STAGEDIR, and gets installed later. I don't think this needs changing.

I have no idea how that software works, or how to enable the building of the documentation in it, so I could not say how to hook it up in the port.

I am not sure what you are saying. You use += when you are appending to a variable. Here, the variable does not exist before, so you do not need to append to it.

Right, missed that bit.

This is wrong, it should be %%PORTDOCS%%.

per IRC the magical missing OPTIONS_DEFINE= DOCS was what was missing. grrr.

latest portlint doesn't like this; I've done this instead:

USES=
USE_RC_SUBR=

CPE_VENDOR=
SHEBANG_FILES=

BTW I've marked this as /done/ as the / is needed here, I assume its the final slash you referred to @mat ?

 make -V WRKDIR
/tmp/usr/ports/databases/couchdb2/work
...
make package
===>  License APACHE20 BSD3CLAUSE ISCL WTFPL OFL11 accepted by the user
===>   couchdb2-2.2.0 depends on file: /usr/local/sbin/pkg - found
=> apache-couchdb-2.2.0.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://www.apache.org/dist/couchdb/source/2.2.0/apache-couchdb-2.2.0.tar.gz
apache-couchdb-2.2.0.tar.gz                             16 MB 1472 kBps    11s
===> Fetching all distfiles required by couchdb2-2.2.0 for building
===>  Extracting for couchdb2-2.2.0
=> SHA256 Checksum OK for apache-couchdb-2.2.0.tar.gz.
===>  Patching for couchdb2-2.2.0
===>  Applying FreeBSD patches for couchdb2-2.2.0
sed: /tmp/usr/ports/databases/couchdb2/work/apache-couchdb-2.2.0configure: No such file or directory
*** Error code 1