deskutils/ganttproject: update to 2.8.8
ClosedPublic
Actions

Authored by fernape on Aug 20 2018, 8:42 PM.

Details

Reviewers

tcberner
tz

Commits

rP478989: deskutils/ganttproject: update to 2.8.8

Summary

Via PR 230768

While here:

Removing INSTALLS_ICONS since this port does not USES=gnome
Change PORTVERSION for DISTVERSION

Test Plan

portlint -AC OK
poudriere builds for {10.4,11.1}{amd64,i386}, 11.2amd64, 12i386 OK
run test in 11.2amd64 OK

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 18986
Build 18624: arc lint + arc unit

Event Timeline

fernape created this revision.Aug 20 2018, 8:42 PM

Herald added a subscriber: mat. · View Herald TranscriptAug 20 2018, 8:42 PM

Harbormaster completed remote builds in B18986: Diff 46998.Aug 20 2018, 8:42 PM

Does this one look reasonable?

You could look at that symlink creation a bit if you have time :) -- otherwise it looks fine.

deskutils/ganttproject/Makefile
34	^ that looks like it could be simplified using ${RLN}

This revision is now accepted and ready to land.Sep 3 2018, 6:36 PM

Fix icons installation.

There is only on 64x64 icon now.

This revision now requires review to proceed.Sep 4 2018, 6:34 PM

Harbormaster completed remote builds in B19388: Diff 47652.Sep 4 2018, 6:34 PM

fernape marked an inline comment as done.Sep 4 2018, 6:37 PM

fernape added inline comments.

deskutils/ganttproject/Makefile

Thanks for pointing this out. It happens that the port was creating broken links for the icons since they pointed to an invalid path:

root@10_4amd64-default:/usr/local/share/icons/hicolor/16x16/apps # file ganttproject.png
ganttproject.png: broken symbolic link to ../../../../../share/ganttproject/plugins/net.sourceforge.ganttproject/data/resources/logos/icon16.png
root@10_4amd64-default:/usr/local/share/icons/hicolor/16x16/apps #

This case is not detected by the QA scripts.

Thanks for fixing that :)

This revision is now accepted and ready to land.Sep 4 2018, 8:02 PM

Closed by commit rP478989: deskutils/ganttproject: update to 2.8.8 (authored by fernape). · Explain WhySep 4 2018, 8:44 PM

This revision was automatically updated to reflect the committed changes.

fernape marked an inline comment as done.