Page MenuHomeFreeBSD
Differential D16803

Merge amd64 and i386 <machine/intr_machdep.h> headers.
ClosedPublic
Actions

Authored by jhb on Aug 19 2018, 5:45 PM.
Tags
None
Referenced Files
F137925077: D16803.id46963.diff
Thu, Nov 27, 7:48 AM
Unknown Object (File)
Fri, Nov 21, 1:36 AM
Unknown Object (File)
Fri, Nov 21, 12:41 AM
Unknown Object (File)
Fri, Nov 21, 12:41 AM
Unknown Object (File)
Fri, Nov 21, 12:36 AM
Unknown Object (File)
Fri, Nov 21, 12:36 AM
Unknown Object (File)
Fri, Nov 21, 12:30 AM
Unknown Object (File)
Tue, Nov 18, 3:50 PM
View All 87 Files
Subscribers
imp
rpokala

Details

Reviewers
kib
Commits
rS338101: Merge amd64 and i386 <machine/intr_machdep.h> headers.
Test Plan
  • build and boot i386 and amd64 GENERIC

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18954
Build 18596: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 19 2018, 5:45 PM
Herald added subscribers: rpokala, imp. · View Herald TranscriptAug 19 2018, 5:45 PM
Harbormaster completed remote builds in B18954: Diff 46941.Aug 19 2018, 5:45 PM
kib added inline comments.Aug 19 2018, 6:05 PM
sys/x86/include/intr_machdep.h
146

In such cases, I leave the structure definition in amd64/include/intr_machdep.h.
Look, for instance, at amd64/include/frame.h.

jhb updated this revision to Diff 46963.Aug 20 2018, 9:41 AM
  • Move nmi_pcpu back to the amd64 header.
Harbormaster completed remote builds in B18966: Diff 46963.Aug 20 2018, 9:41 AM
kib accepted this revision.Aug 20 2018, 10:49 AM
This revision is now accepted and ready to land.Aug 20 2018, 10:49 AM
Closed by commit rS338101: Merge amd64 and i386 <machine/intr_machdep.h> headers. (authored by jhb). · Explain WhyAug 20 2018, 12:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
amd64/
include/
199 lines
i386/
include/
190 lines
x86/
include/
amd64/
include/
10 lines

Diff 46941

View Options

sys/amd64/include/intr_machdep.h

Loading...
View Options

sys/i386/include/intr_machdep.h

Loading...
View Options

sys/x86/include/intr_machdep.h

Loading...