Page MenuHomeFreeBSD
Differential D16708

Move all shell related files to bin/sh/ and bin/csh/
ClosedPublic
Actions

Authored by brd on Aug 14 2018, 2:14 PM.
Tags
None
Referenced Files
F146224554: D16708.id.diff
Sat, Feb 28, 9:57 PM
F146201171: D16708.id46659.diff
Sat, Feb 28, 5:14 PM
F146148455: D16708.id46659.diff
Sat, Feb 28, 5:52 AM
Unknown Object (File)
Fri, Feb 27, 5:40 AM
Unknown Object (File)
Sun, Feb 15, 9:26 AM
Unknown Object (File)
Mon, Feb 9, 12:23 PM
Unknown Object (File)
Jan 11 2026, 11:10 AM
Unknown Object (File)
Jan 10 2026, 10:27 PM
View All Files
Subscribers
imp

Details

Reviewers
will
allanjude
jilles
Commits
rS337849: Move all sh and csh files into bin/sh/ or bin/csh/
Test Plan

Compare the results from make distribution

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18787
Build 18454: arc lint + arc unit

Event Timeline

brd created this revision.Aug 14 2018, 2:14 PM
Herald added a reviewer: jilles. · View Herald TranscriptAug 14 2018, 2:14 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B18787: Diff 46659.Aug 14 2018, 2:14 PM
will requested changes to this revision.Aug 14 2018, 8:57 PM

Issues using LINKS, on cursory inspection.

bin/csh/Makefile
53

bsd.links.mk prepends ${DESTDIR} to both source and target.

bin/sh/Makefile
40

See above.

68

Why is this appropriate for this particular file?

This revision now requires changes to proceed.Aug 14 2018, 8:57 PM
brd updated this revision to Diff 46696.Aug 15 2018, 10:46 AM
brd marked 2 inline comments as done.

Update to remove DESTDIR from LINKS

Harbormaster completed remote builds in B18805: Diff 46696.Aug 15 2018, 10:47 AM
brd added inline comments.Aug 15 2018, 10:48 AM
bin/sh/Makefile
68

That is what we do today in etc/Makefile.. but it has been there for almost 10 years, so perhaps it is time for it to go.

will accepted this revision.Aug 15 2018, 2:10 PM
This revision is now accepted and ready to land.Aug 15 2018, 2:10 PM
Closed by commit rS337849: Move all sh and csh files into bin/sh/ or bin/csh/ (authored by brd). · Explain WhyAug 15 2018, 2:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46659

View Options

bin/csh/Makefile

Loading...
View Options

bin/csh/csh.cshrc

Loading...
View Options

bin/csh/csh.login

Loading...
View Options

bin/csh/csh.logout

Loading...
View Options

bin/csh/dot.cshrc

Loading...
View Options

bin/csh/dot.login

Loading...
View Options

bin/sh/Makefile

Loading...
View Options

bin/sh/dot.profile

Loading...
View Options

bin/sh/profile

Loading...
View Options

etc/Makefile

Loading...
View Options

etc/csh.cshrc

Loading...
View Options

etc/csh.login

Loading...
View Options

etc/csh.logout

Loading...
View Options

etc/profile

Loading...
View Options

etc/root/dot.cshrc

Loading...
View Options

etc/root/dot.login

Loading...
View Options

etc/root/dot.profile

Loading...