Page MenuHomeFreeBSD
Differential D16625

sbin/init/init.c: Add init_exec
ClosedPublic
Actions

Authored by trasz on Aug 8 2018, 1:04 PM.
Tags
None
Referenced Files
F105790031: D16625.diff
Fri, Dec 20, 5:51 PM
Unknown Object (File)
Sun, Dec 15, 11:52 AM
Unknown Object (File)
Thu, Dec 12, 2:06 PM
Unknown Object (File)
Oct 5 2024, 8:39 PM
Unknown Object (File)
Oct 2 2024, 8:27 PM
Unknown Object (File)
Sep 30 2024, 5:23 PM
Unknown Object (File)
Sep 30 2024, 2:59 PM
Unknown Object (File)
Sep 30 2024, 1:39 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
imp
Group Reviewers
manpages
Commits
rS337740: Add init_exec kenv(1) variable, to make init(8) execute a file
Summary

Add init_exec kenv(1) variable, to make init(8) execute the file
after opening the console, replacing init as PID 1.

From the user point of view, it makes it possible to run eg the
shell as PID 1, using 'set init_exec=/bin/sh' at the loader(8) prompt.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18775
Build 18444: arc lint + arc unit

Event Timeline

trasz created this revision.Aug 8 2018, 1:04 PM
Herald added a reviewer: manpages. · View Herald TranscriptAug 8 2018, 1:04 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B18642: Diff 46408.Aug 8 2018, 1:04 PM
trasz added reviewers: kib, imp.Aug 8 2018, 1:04 PM

This also introduces execute_script() and refactors code a bit. My plan is to commit this part (refactoring) first, and the actual new functionality and man page updates later.

kib added a comment.Aug 8 2018, 1:35 PM

Please split the review into refactor and new functionality. Lets handle the refactoring first.

trasz added a comment.Aug 8 2018, 2:35 PM

Done, see https://reviews.freebsd.org/D16627.

linimon retitled this revision from Add init_exec to sbin/init/init.c: Add init_exec.Aug 9 2018, 3:53 AM
trasz updated this revision to Diff 46460.Aug 9 2018, 12:21 PM

Regen.

Harbormaster completed remote builds in B18664: Diff 46460.Aug 9 2018, 12:21 PM
kib added inline comments.Aug 9 2018, 1:08 PM
sbin/init/init.c
340

Should be NULL.

Also, why do you use '_' namespace ?

And, I suggest to move the locals to the common declaration block.

trasz added inline comments.Aug 9 2018, 1:27 PM
sbin/init/init.c
340

The '_' is because I wan't to avoid shadowing argv - the one passed to main(). The declarations... Normally I'd do that, but decided to comply with the way it's being done in other places in this file, which is keeping it local.

trasz updated this revision to Diff 46465.Aug 9 2018, 1:27 PM

Use NULL.

Harbormaster completed remote builds in B18669: Diff 46465.Aug 9 2018, 1:27 PM
trasz updated this revision to Diff 46633.Aug 13 2018, 6:51 PM

Move the code to a separate function.

Harbormaster completed remote builds in B18774: Diff 46633.Aug 13 2018, 6:51 PM
trasz updated this revision to Diff 46634.Aug 13 2018, 6:56 PM

Move stuff around.

Harbormaster completed remote builds in B18775: Diff 46634.Aug 13 2018, 6:56 PM
trasz marked an inline comment as done.Aug 13 2018, 6:57 PM
kib accepted this revision.Aug 13 2018, 7:22 PM
This revision is now accepted and ready to land.Aug 13 2018, 7:22 PM
Closed by commit rS337740: Add init_exec kenv(1) variable, to make init(8) execute a file (authored by trasz). · Explain WhyAug 14 2018, 11:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
init/
10 lines
22 lines
stand/
man/
3 lines

Diff 46634

View Options

sbin/init/init.8

Loading...
View Options

sbin/init/init.c

Loading...
View Options

stand/man/loader.8

Loading...