Page MenuHomeFreeBSD
Differential D16622

arm/ralink cleanup and delete NON INTRNG code
ClosedPublic
Actions

Authored by yamori813_yahoo.co.jp on Aug 8 2018, 8:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 22, 7:22 AM
Unknown Object (File)
Wed, Jan 22, 2:33 AM
Unknown Object (File)
Tue, Jan 21, 11:09 PM
Unknown Object (File)
Tue, Jan 21, 5:23 PM
Unknown Object (File)
Tue, Jan 21, 7:49 AM
Unknown Object (File)
Dec 20 2024, 12:25 PM
Unknown Object (File)
Dec 12 2024, 11:57 PM
Unknown Object (File)
Nov 16 2024, 9:41 PM
View All 64 Files
Subscribers
andrew
manu

Details

Reviewers
adrian
mizhka
imp
Commits
rS337822: arm/ralink cleanup
Test Plan

on Buffalo_WZR2-G300N

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18690
Build 18373: arc lint + arc unit

Event Timeline

yamori813_yahoo.co.jp created this revision.Aug 8 2018, 8:04 AM
Harbormaster completed remote builds in B18637: Diff 46402.Aug 8 2018, 8:04 AM
imp accepted this revision.Aug 8 2018, 6:10 PM

generally I like it, but there's two unrelated changes, I think, in here.

sys/arm/ralink/rt1310_machdep.c
35 ↗(On Diff #46402)

this looks unintentional...

127 ↗(On Diff #46402)

this looks unintentional...

This revision is now accepted and ready to land.Aug 8 2018, 6:10 PM
yamori813_yahoo.co.jp updated this revision to Diff 46439.Aug 8 2018, 9:57 PM
  • too mach delete INTRNG
  • refict review
This revision now requires review to proceed.Aug 8 2018, 9:57 PM
Harbormaster completed remote builds in B18654: Diff 46439.Aug 8 2018, 9:57 PM
imp accepted this revision.Aug 8 2018, 9:58 PM

Perfect! Thank you for such a prompt cleanup.

This revision is now accepted and ready to land.Aug 8 2018, 9:58 PM
yamori813_yahoo.co.jp updated this revision to Diff 46493.Aug 10 2018, 5:14 AM
  • forget add kernel address setting
This revision now requires review to proceed.Aug 10 2018, 5:14 AM
Harbormaster completed remote builds in B18690: Diff 46493.Aug 10 2018, 5:14 AM
imp accepted this revision.Aug 10 2018, 1:47 PM

I'll commit this later today if there's no objections

This revision is now accepted and ready to land.Aug 10 2018, 1:47 PM
manu added a subscriber: manu.Aug 10 2018, 2:03 PM
manu added inline comments.
sys/arm/ralink/std.ralink
11

Is PHYADDR needed ?
It seems that it's only needed if KERNVIRTADDR!=KERNBASE or if one use FLASHADDR/LOADERADDR

imp added inline comments.Aug 11 2018, 2:46 PM
sys/arm/ralink/std.ralink
11

Looking at the code, I agree. It appears to be copied from the kirkwood config files, where at least one of them does actually use it. I'm going to leave it to get this change in.

Closed by commit rS337822: arm/ralink cleanup (authored by imp). · Explain WhyAug 14 2018, 8:45 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: andrew. · View Herald TranscriptAug 14 2018, 8:46 PM

Revision Contents
Changeset List

PathSize
sys/
arm/
ralink/
105 lines
27 lines
5 lines

Diff 46493

View Options

sys/arm/ralink/rt1310_intc.c

Loading...
View Options

sys/arm/ralink/rt1310var.h

Loading...
View Options

sys/arm/ralink/std.ralink

Loading...