Page MenuHomeFreeBSD
Differential D16630

graphics/converseen: update to 0.9.7
ClosedPublic
Actions

Authored by fernape on Aug 8 2018, 5:17 PM.
Tags
None
Referenced Files
F141018783: D16630.id.diff
Tue, Dec 30, 8:03 PM
F141011147: D16630.id46419.diff
Tue, Dec 30, 5:47 PM
F141005111: D16630.id46425.diff
Tue, Dec 30, 4:02 PM
F141003951: D16630.id46424.diff
Tue, Dec 30, 3:43 PM
Unknown Object (File)
Sat, Dec 27, 10:34 PM
Unknown Object (File)
Tue, Dec 23, 7:09 PM
Unknown Object (File)
Fri, Dec 19, 11:11 AM
Unknown Object (File)
Fri, Dec 19, 11:11 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
tz
Commits
rP476654: graphics/converseen: update to 0.9.7
Summary

Also:

  • PORTVERSION to DISTVERSION
  • Switch to Github site
  • Sort USES and USE_QT
Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • run test in 11.2 OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 18645
Build 18332: arc lint + arc unit

Event Timeline

fernape created this revision.Aug 8 2018, 5:17 PM
Herald added a subscriber: mat. · View Herald TranscriptAug 8 2018, 5:17 PM
Harbormaster completed remote builds in B18645: Diff 46419.Aug 8 2018, 5:17 PM
tcberner added inline comments.Aug 8 2018, 5:40 PM
graphics/converseen/Makefile
16

^ try to use cmake:outsource.

17

^ I prefer it like so:

USE_QT= core gui network widgets  \
        buildtools_build linguisttools_build qmake_build

[group the build-only ones] -- you don't have to do it :)

26

^ is the patch to conversen.pro needed when using cmake?

fernape updated this revision to Diff 46424.Aug 8 2018, 6:17 PM
  • Sort USES_QT by kind
  • Remove unnecessary patch
Harbormaster completed remote builds in B18648: Diff 46424.Aug 8 2018, 6:17 PM
fernape marked 2 inline comments as done.Aug 8 2018, 6:18 PM
fernape updated this revision to Diff 46425.Aug 8 2018, 6:20 PM

Out of source building.

Harbormaster completed remote builds in B18649: Diff 46425.Aug 8 2018, 6:20 PM
fernape marked an inline comment as done.Aug 8 2018, 6:21 PM
tcberner accepted this revision.Aug 8 2018, 6:24 PM

Macro lgtm:

This revision is now accepted and ready to land.Aug 8 2018, 6:24 PM
fernape added a comment.Aug 8 2018, 6:26 PM
In D16630#353392, @tcberner wrote:

Macro lgtm:

Cool :-)

Closed by commit rP476654: graphics/converseen: update to 0.9.7 (authored by fernape). · Explain WhyAug 8 2018, 6:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
graphics/
converseen/
16 lines
6 lines
1 line

Diff 46419

View Options

graphics/converseen/Makefile

Loading...
View Options

graphics/converseen/distinfo

Loading...
View Options

graphics/converseen/pkg-plist

Loading...