Fix page accounting in kmem_bootstrap_free().
ClosedPublic
Actions

Authored by markj on Aug 3 2018, 3:15 PM.

Details

Reviewers

kib
alc

Commits

rS337265: Add the required page accounting to kmem_bootstrap_free().

Summary

We need to adjust v_free_count and v_page_count since we are freeing
directly to the physical memory allocator.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 3 2018, 3:15 PM

Harbormaster completed remote builds in B18549: Diff 46235.Aug 3 2018, 3:15 PM

markj added reviewers: kib, alc.Aug 3 2018, 3:38 PM

kib added inline comments.Aug 3 2018, 3:44 PM

sys/vm/vm_kern.c
720 ↗	(On Diff #46235)	What if the allocation span more than one domain ? I agree that this is unlikely.

markj added inline comments.Aug 3 2018, 3:48 PM

sys/vm/vm_kern.c
720 ↗	(On Diff #46235)	Sigh, thanks. I lifted this out of the loop without thinking.

Move accounting into the loop.

Harbormaster completed remote builds in B18552: Diff 46243.Aug 3 2018, 3:50 PM

Adjust the per-domain page count too.

Harbormaster completed remote builds in B18554: Diff 46245.Aug 3 2018, 3:52 PM

kib accepted this revision.Aug 3 2018, 4:17 PM

This revision is now accepted and ready to land.Aug 3 2018, 4:17 PM

alc accepted this revision.Aug 3 2018, 4:32 PM

Closed by commit rS337265: Add the required page accounting to kmem_bootstrap_free(). (authored by markj). · Explain WhyAug 3 2018, 4:35 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptAug 3 2018, 4:35 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_kern.c

4 lines

Diff 46250

View Options

Fix page accounting in kmem_bootstrap_free().ClosedPublicActions