Page MenuHomeFreeBSD

www/moinmoin: Add recaptcha v2 and verifyemail support patches
ClosedPublic

Authored by koobs on Jul 18 2018, 3:52 AM.
Tags
None
Referenced Files
F87539811: D16315.id45444.diff
Thu, Jul 4, 5:26 PM
F87539755: D16315.id46005.diff
Thu, Jul 4, 5:24 PM
F87538320: D16315.id45449.diff
Thu, Jul 4, 4:51 PM
F87538305: D16315.id46004.diff
Thu, Jul 4, 4:51 PM
Unknown Object (File)
Tue, Jul 2, 2:25 PM
Unknown Object (File)
Tue, Jun 25, 8:50 AM
Unknown Object (File)
Sat, Jun 8, 1:11 AM
Unknown Object (File)
Thu, Jun 6, 10:56 PM

Details

Summary
www/moinmoin: Add recaptcha v2 and email verification support

Add patches to include:

   - reCAPTCHA v2 support [1]
   - Email verification for new account creation [2]
     
Both patches are OPTION'al, both OPTIONS are enabled by default. Both features
require additional configuration (within moinmoin) to enable them within wiki
instances. 

While I'm here:

  - Use TLS for MASTER_SITES and pkg-descr WWW: URLs
  - Update COMMENT to match setup.py description
  - Enable NO_ARCH
  - Sort sections
  
PR:		227394 [1]
Submitted by:	<daz hackerspace pl> [1]
Approved by:	koobs (python, maintainer)
Obtained from:	clusteradm (sbruno, custom patch to port) [2]
Differential_Revision:	D16315
Test Plan
  • portlint: WARN (0 delta with changes)
  • testport: OK (poudriere)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

www/moinmoin/Makefile
17–25 ↗(On Diff #45444)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

koobs edited the summary of this revision. (Show Details)
0mp accepted this revision.EditedJul 18 2018, 8:41 PM

It's great that it's landing soon! Great work.

I've tested it as you asked me to. Here are the steps

  1. Install and configure MoinMoin as descirbed here: https://wiki.freebsd.org/Ports/www/moinmoin
  2. Check that the wiki is available on http://localhost/
  3. Apply the patch: cd /usr/ports && patch -p0 < recaptcha.patch
  4. cd /usr/ports/www/moinmoin && make clean && make deinstall && make install && make MOINTYPE=WSGI instance
  5. Restart nginx and uwsgi services.
  6. Check that the wiki is available on http://localhost/
www/moinmoin/Makefile
35 ↗(On Diff #45449)

I think I'd write support with lowercase to match the sentence-like style of VERIFYMAIL_DESC.

This revision is now accepted and ready to land.Jul 18 2018, 8:41 PM
This revision now requires review to proceed.Jul 29 2018, 11:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 30 2018, 12:05 AM
This revision was automatically updated to reflect the committed changes.