Send consistent SEG.WIN when sending from the timewait code path
ClosedPublic
Actions

Authored by tuexen on Jul 29 2018, 10:17 PM.

Details

Reviewers

lstewart
jason_eggnet.com
rrs

Group Reviewers

transport

Commits

rS336937: Send consistent SEG.WIN when using timewait codepath for TCP.

Summary

When creating a timewait entry, the last sent rcv window is stored. However, it is computed in a different way than in the main code path. This results in inconsistencies. These are fixed by using the same code as in tcp_output().

Test Plan

Run the attached packetdrill test.

lastack.pkt2 KBDownload

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 18422

Event Timeline

tuexen created this revision.Jul 29 2018, 10:17 PM

Herald added a reviewer: transport. · View Herald TranscriptJul 29 2018, 10:17 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B18422: Diff 46002.Jul 29 2018, 10:17 PM

rrs accepted this revision.Jul 30 2018, 10:19 AM

This revision is now accepted and ready to land.Jul 30 2018, 10:19 AM

Closed by commit rS336937: Send consistent SEG.WIN when using timewait codepath for TCP. (authored by tuexen). · Explain WhyJul 30 2018, 9:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_timewait.c

16 lines

Diff 46002

View Options

sys/netinet/tcp_timewait.c

Send consistent SEG.WIN when sending from the timewait code pathClosedPublicActions