libtls.mk for handling linking with libtls
AbandonedPublic
Actions

Authored by tobik on Jul 26 2018, 11:23 AM.

Details

Reviewers

None

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Summary

Some ports need to link with libtls as provided by LibreSSL. The
current approach in the ports tree is to statically link ports
against it.

Some ports invent their own method to do this. Sometimes this
introduces new problems on LibreSSL updates c.f. PR 228438. I
think it would be good to provide something in the framework
to do this.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 18346
Build 18065: arc lint + arc unit

Event Timeline

tobik created this revision.Jul 26 2018, 11:23 AM

Owners added a reviewer: O5: Ports Framework.Jul 26 2018, 11:23 AM

Herald added a reviewer: portmgr. · View Herald TranscriptJul 26 2018, 11:23 AM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B18346: Diff 45870.Jul 26 2018, 11:23 AM

I really never liked ports ignoring the SSL library I choose and building and linking with LibreSSL anyway.
I still think that when libressl is not the default they should error out.

leres added a subscriber: leres.Jul 26 2018, 3:53 PM

In D16454#349248, @mat wrote:

I really never liked ports ignoring the SSL library I choose and building and linking with LibreSSL anyway.
I still think that when libressl is not the default they should error out.

In this case these don't link to libssl or libcrypto from the chosen SSL implementation.
These link to libtls, which is provided by libressl packages.

Rebase after rP476218

Harbormaster completed remote builds in B18515: Diff 46172.Aug 2 2018, 5:45 AM

tobik abandoned this revision.Oct 11 2018, 6:34 AM