Page MenuHomeFreeBSD

Add Mk/Uses/libtls.mk for handling linking with libtls
AbandonedPublic

Authored by tobik on Jul 26 2018, 11:23 AM.

Details

Reviewers
None
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

Some ports need to link with libtls as provided by LibreSSL. The
current approach in the ports tree is to statically link ports
against it.

Some ports invent their own method to do this. Sometimes this
introduces new problems on LibreSSL updates c.f. PR 228438. I
think it would be good to provide something in the framework
to do this.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18515
Build 18220: arc lint + arc unit

Event Timeline

tobik created this revision.Jul 26 2018, 11:23 AM
mat added a comment.Jul 26 2018, 11:38 AM

I really never liked ports ignoring the SSL library I choose and building and linking with LibreSSL anyway.
I still think that when libressl is not the default they should error out.

leres added a subscriber: leres.Jul 26 2018, 3:53 PM
In D16454#349248, @mat wrote:

I really never liked ports ignoring the SSL library I choose and building and linking with LibreSSL anyway.
I still think that when libressl is not the default they should error out.

In this case these don't link to libssl or libcrypto from the chosen SSL implementation.
These link to libtls, which is provided by libressl packages.

tobik updated this revision to Diff 46172.Aug 2 2018, 5:45 AM

Rebase after rP476218

tobik abandoned this revision.Oct 11 2018, 6:34 AM