Page MenuHomeFreeBSD
Differential D16333

The ICMP echo is too small
ClosedPublic
Actions

Authored by rrs on Jul 18 2018, 10:46 PM.
Tags
None
Referenced Files
F105720255: D16333.id45501.diff
Thu, Dec 19, 4:49 PM
F105711495: D16333.diff
Thu, Dec 19, 1:52 PM
Unknown Object (File)
Wed, Dec 18, 2:26 PM
Unknown Object (File)
Oct 23 2024, 9:14 PM
Unknown Object (File)
Oct 9 2024, 8:24 PM
Unknown Object (File)
Oct 3 2024, 8:01 PM
Unknown Object (File)
Oct 2 2024, 5:10 PM
Unknown Object (File)
Sep 28 2024, 4:21 AM
View All 47 Files
Subscribers
imp

Details

Reviewers
tuexen
Group Reviewers
transport
Commits
rS336465: Bump the ICMP echo limits to match the RFC
Summary

The amount we echo (8 bytes) is from the 1980's and the router requirements document
requires it to be much higher

Test Plan

Grow it and make sure we reflect larger packets back

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rrs created this revision.Jul 18 2018, 10:46 PM
tuexen accepted this revision.Jul 18 2018, 10:48 PM

Add a fullstop at the end of the comment.

This revision is now accepted and ready to land.Jul 18 2018, 10:48 PM
Closed by commit rS336465: Bump the ICMP echo limits to match the RFC (authored by rrs). · Explain WhyJul 18 2018, 10:50 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJul 18 2018, 10:50 PM

Revision Contents
Changeset List

PathSize
4 lines

Diff 45501

View Options

ip_icmp.c

Loading...