www/gitlab-ce: make it possible to use another PREFIX for gitlab-ce.
ClosedPublic
Actions

Authored by mfechner on Jul 14 2018, 8:42 AM.

Details

Reviewers

tz
swills

Commits

rP474906: Made it possible to use another PREFIX for gitlab-ce.
rP474905: Made it possible to use another PREFIX for gitlab-ce.

Summary

I think it makes sense here to commit it in one commit as it belongs together.

Commit message:
Made it possible to use another PREFIX for gitlab-ce.

Add reported/suggested by swills

Test Plan

I did a make patch and checked that all files are correctly patched.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mfechner created this revision.Jul 14 2018, 8:42 AM

Herald added a subscriber: mat. · View Herald TranscriptJul 14 2018, 8:42 AM

Included the gitlab startup file.

swills added inline comments.Jul 16 2018, 4:24 PM

www/gitlab-ce/Makefile
230 ↗	(On Diff #45277)	Only call REINPLACE_CMD once, ie something like: ${REINPLACE_CMD} -e "s\|%%PREFIX%%\|${PREFIX}\|" ${WRKSRC}/config/gitlab.yml.example \ ${WRKSRC}/config/unicorn.rb.example ${WRKSRC}/lib/support/nginx/gitlab \ ${WRKSRC}/lib/support/nginx/gitlab-ssl (ignore spacing issues due to phabricator)

Updated SED to be in one line and added PORTREVISION to gitaly port.

mfechner marked an inline comment as done.Jul 17 2018, 10:15 PM

linimon retitled this revision from Made it possible to use another PREFIX for gitlab-ce. to www/gitlab-ce: make it possible to use another PREFIX for gitlab-ce..Jul 18 2018, 12:48 PM

Thanks, approved

This revision is now accepted and ready to land.Jul 18 2018, 4:51 PM

Closed by commit rP474905: Made it possible to use another PREFIX for gitlab-ce. (authored by mfechner). · Explain WhyJul 18 2018, 9:53 PM

This revision was automatically updated to reflect the committed changes.