Differential D16296
Add myself (0mp) as a ports committer, add my key, update news and adapt some tools to my username. Authored by 0mp on Jul 17 2018, 12:07 AM. Tags None Referenced Files
Details Apart from the files I am supposed to update with my information I also edited two scripts, which didn't work due to the leading 0 in my username. Those scripts are share/pgpkeys/checkkey.sh and share/pgpkeys/addkey.sh. I guess I should update those scripts in a separate commit, right?
Diff Detail
Event TimelineComment Actions Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999. Comment Actions Thanks, @mat! I was always curious why Phabricator does not add any context to my diffs. Here's a diff generated with svn diff -x -U9999. I'll try to get familiar with the arcanist soon. Comment Actions This looks ok to me, you can commit the changes, but for the scripts, I would still like feedback from their authors. |