rc is initialized to 0. Returning 0 here would indicate success.
Return EINVAL instead to indicate the error.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| sys/dev/xen/blkfront/blkfront.c | ||
|---|---|---|
| 605 | length is of type size_t, which is an unsigned type, so checking it against < 0 is useless. Also if length == 0 you should just return 0. C
if ( length == 0)
return 0;Is IMO the correct fix. Although the code is already functionally correct because it returns 0 when length == 0, which is fine. | |