Page MenuHomeFreeBSD
Differential D15996

Add PNP info to PCI attachment of arcmsr, bt, cbb, de, ebus, emujoy, fixup_pci, hifn, hptiop, imcsmb, snd_emu10k1 (emu_pci) drivers
ClosedPublic
Actions

Authored by lakhanshiva_gmail.com on Jun 24 2018, 12:07 PM.
Tags
None
Referenced Files
F149396852: D15996.id44569.diff
Tue, Mar 24, 4:35 AM
Unknown Object (File)
Sun, Mar 22, 10:40 PM
Unknown Object (File)
Sat, Mar 14, 2:03 AM
Unknown Object (File)
Mon, Mar 9, 3:29 PM
Unknown Object (File)
Mon, Mar 9, 9:50 AM
Unknown Object (File)
Sun, Mar 8, 9:28 PM
Unknown Object (File)
Sun, Mar 8, 9:02 PM
Unknown Object (File)
Sun, Mar 8, 5:24 PM
View All Files
Subscribers
lakhan

Details

Reviewers
imp
chuck
Summary

Add PNP info to PCI attachment of hptiop driver

Add PNP info to PCI attachment of arcmsr driver

Add PNP info to PCI attachment of hifn driver

Add PNP INFO to PCI attachment of bt driver

Add PNP info to PCI attachment of emujoy, snd_emu10k1 (emu_pci) drivers

Add PNP info to PCI attachments of ebus driver

Add PNP info to PCI attachments of cbb driver

Add PNP info to PCI attachments of de driver

Add PNP info to PCI attachments of fixup_pci driver

Add PNP info to PCI attachment of imcsmb driver

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17683
Build 17488: arc lint + arc unit

Event Timeline

lakhanshiva_gmail.com created this revision.Jun 24 2018, 12:07 PM
Harbormaster completed remote builds in B17591: Diff 44386.Jun 24 2018, 12:07 PM
lakhanshiva_gmail.com updated this revision to Diff 44565.Jun 28 2018, 1:47 AM
  • Update PNP info to PCI attachment of arcmsr driver
Harbormaster completed remote builds in B17683: Diff 44565.Jun 28 2018, 1:47 AM
lakhanshiva_gmail.com updated this revision to Diff 44567.Jun 28 2018, 2:10 AM
  • Update PNP info to PCI attachment of hptiop driver
  • Update PNP INFO to PCI attachment of bt driver
  • Update PNP info to PCI attachment of emujoy, snd_emu10k1 (emu_pci) drivers
  • Update PNP info to PCI attachments of cbb driver
  • Update PNP info to PCI attachments of fixup_pci driver
  • Update PNP info to PCI attachment of imcsmb driver
Harbormaster completed remote builds in B17685: Diff 44567.Jun 28 2018, 2:10 AM
lakhanshiva_gmail.com updated this revision to Diff 44568.Jun 28 2018, 2:19 AM
  • Update PNP info to PCI attachments of ebus driver
Harbormaster completed remote builds in B17686: Diff 44568.Jun 28 2018, 2:19 AM
lakhanshiva_gmail.com updated this revision to Diff 44569.Jun 28 2018, 2:45 AM
  • Update PNP INFO to PCI attachment of bt driver
Harbormaster completed remote builds in B17687: Diff 44569.Jun 28 2018, 2:46 AM
lakhanshiva_gmail.com updated this revision to Diff 44570.Jun 28 2018, 3:02 AM
  • Update PNP info to PCI attachment of arcmsr driver
  • Update PNP INFO to PCI attachment of bt driver
  • Update PNP info to PCI attachment of emujoy, snd_emu10k1 (emu_pci) drivers
Harbormaster completed remote builds in B17688: Diff 44570.Jun 28 2018, 3:02 AM
imp added inline comments.Jun 28 2018, 4:42 AM
sys/dev/buslogic/bt_pci.c
121–135

This doesn't look right at all...

lakhanshiva_gmail.com updated this revision to Diff 44714.Jul 1 2018, 10:52 AM
  • Update PNP info to PCI attachment of arcmsr driver
  • Update PNP info to PCI attachment of hifn driver
  • Update PNP INFO to PCI attachment of bt driver
  • Update PNP info to PCI attachments of ebus driver
Harbormaster completed remote builds in B17760: Diff 44714.Jul 1 2018, 10:52 AM
chuck added inline comments.Jul 3 2018, 3:41 PM
sys/dev/buslogic/bt_pci.c
126

Since the bt_devs[] is null terminated, shouldn't the bounds check be nitems() instead of nitems() - 1?

sys/dev/hptiop/hptiop.c
1857

Should this get converted to using the new table of devices?

sys/sparc64/ebus/ebus.c
285

Should the check be for nitems()?

lakhanshiva_gmail.com added inline comments.Jul 3 2018, 3:54 PM
sys/dev/buslogic/bt_pci.c
126

So, in this case nitems(bt_devs) comes out to be 3, so the for loop is for(i=0; i<2; i++). This iterates through the two valid devices present in bt_devs. It doesn't check the sentinel. This is what i wanted to iterate on. Does it sound right ?

lakhanshiva_gmail.com updated this revision to Diff 44891.Jul 5 2018, 7:51 AM
lakhanshiva_gmail.com updated this revision to Diff 44892.
lakhanshiva_gmail.com edited the summary of this revision. (Show Details)
lakhanshiva_gmail.com edited the summary of this revision. (Show Details)
lakhanshiva_gmail.com updated this revision to Diff 44893.Jul 5 2018, 8:07 AM
lakhanshiva_gmail.com updated this revision to Diff 44931.Jul 5 2018, 6:28 PM
lakhanshiva_gmail.com marked an inline comment as done.Jul 5 2018, 6:38 PM
lakhanshiva_gmail.com added inline comments.
sys/dev/hptiop/hptiop.c
1857

Made the probe routine table driven. Same in other cases where it is necessary.

lakhanshiva_gmail.com marked 2 inline comments as done.Jul 5 2018, 6:39 PM
chuck accepted this revision.Dec 31 2018, 7:13 PM
This revision is now accepted and ready to land.Dec 31 2018, 7:13 PM
chuck closed this revision.Dec 31 2018, 7:14 PM
afedorov mentioned this in D30618: arm64: add snd_hda to GENERIC.Jun 3 2021, 2:54 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
arcmsr/
92 lines
buslogic/
79 lines
de/
17 lines
hifn/
17 lines
hptiop/
38 lines
imcsmb/
21 lines
pccbb/
2 lines
pci/
11 lines
sound/
pci/
27 lines
sparc64/
ebus/
34 lines

Diff 44565

View Options

sys/dev/arcmsr/arcmsr.c

Loading...
View Options

sys/dev/buslogic/bt_pci.c

Loading...
View Options

sys/dev/de/if_de.c

Loading...
View Options

sys/dev/hifn/hifn7751.c

Loading...
View Options

sys/dev/hptiop/hptiop.c

Loading...
View Options

sys/dev/imcsmb/imcsmb_pci.c

Loading...
View Options

sys/dev/pccbb/pccbb_pci.c

Loading...
View Options

sys/dev/pci/fixup_pci.c

Loading...
View Options

sys/dev/sound/pci/emu10k1.c

Loading...
View Options

sys/sparc64/ebus/ebus.c

Loading...