Page MenuHomeFreeBSD
Differential D2152

libc: Eliminate duplicate copies of __vdso_gettc.c
ClosedPublic
Actions

Authored by emaste on Mar 27 2015, 1:42 AM.
Tags
None
Referenced Files
F93755595: D2152.diff
Thu, Sep 12, 6:13 AM
Unknown Object (File)
Wed, Sep 4, 8:08 PM
Unknown Object (File)
Wed, Sep 4, 7:31 PM
Unknown Object (File)
Wed, Sep 4, 6:44 PM
Unknown Object (File)
Fri, Aug 30, 11:09 PM
Unknown Object (File)
Fri, Aug 30, 11:09 PM
Unknown Object (File)
Fri, Aug 30, 11:09 PM
Unknown Object (File)
Thu, Aug 29, 1:01 PM
View All 61 Files
Subscribers
None

Details

Reviewers
kib
andrew
imp
Commits
rS281004: libc: Eliminate duplicate copies of __vdso_gettc.c

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 4449.Mar 27 2015, 1:42 AM
emaste retitled this revision from to libc: Eliminate duplicate copies of __vdso_gettc.c.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: imp, andrew, kib.
kib accepted this revision.Mar 27 2015, 9:30 AM
kib edited edge metadata.

I am fine with it.

Myself, I would use the name trivial_vdso_tc.c, but it is only a weak suggestion.

This revision is now accepted and ready to land.Mar 27 2015, 9:30 AM
emaste added inline comments.Apr 2 2015, 5:35 PM
lib/libc/arm/sys/Makefile.inc
3

I went with trivial- for consistency with the getcontextx change, but I agree this is a bit awkward. I might use trivial-vdso_tc.c instead.

emaste closed this revision.Apr 2 2015, 9:18 PM
emaste updated this revision to Diff 4622.

Closed by commit rS281004 (authored by @emaste).

Revision Contents
Changeset List

PathSize
lib/
libc/
arm/
sys/
2 lines
mips/
sys/
2 lines
powerpc/
2 lines
sys/
powerpc64/
2 lines
sys/
sparc64/
2 lines
sys/
sys/
48 lines

Diff 4449

View Options

lib/libc/arm/sys/Makefile.inc

Loading...
View Options

lib/libc/arm/sys/__vdso_gettc.c

Loading...
View Options

lib/libc/mips/sys/Makefile.inc

Loading...
View Options

lib/libc/mips/sys/__vdso_gettc.c

Loading...
View Options

lib/libc/powerpc/Makefile.inc

Loading...
View Options

lib/libc/powerpc/sys/__vdso_gettc.c

Loading...
View Options

lib/libc/powerpc64/Makefile.inc

Loading...
View Options

lib/libc/powerpc64/sys/__vdso_gettc.c

Loading...
View Options

lib/libc/sparc64/Makefile.inc

Loading...
View Options

lib/libc/sparc64/sys/__vdso_gettc.c

Loading...
View Options

lib/libc/sys/trivial-__vdso_gettc.c

Loading...