Page MenuHomeFreeBSD

Do not access ISA timer if BIOS reports that there is no legacy devices present.
ClosedPublic

Authored by kib on Jun 25 2018, 9:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 22 2024, 11:03 PM
Unknown Object (File)
Sep 21 2024, 4:45 AM
Unknown Object (File)
Sep 20 2024, 7:01 PM
Unknown Object (File)
Sep 8 2024, 9:06 PM
Unknown Object (File)
Sep 4 2024, 3:01 PM
Unknown Object (File)
Sep 4 2024, 6:51 AM
Unknown Object (File)
Aug 17 2024, 7:34 AM
Unknown Object (File)
Aug 17 2024, 5:13 AM
Subscribers

Details

Summary

I did not committed this because on the computer where ISA timer is gated, bios really reports that ISA devices are present.
But I think now that acpi_get_fadt_bootflags() is useful on its own.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I would like to use acpi_get_fadt_bootflags for vt also, but then it needs to live in some generic ACPI file, or else I would have to provide dummy implementations for !x86 arches.

I would like to use acpi_get_fadt_bootflags for vt also, but then it needs to live in some generic ACPI file, or else I would have to provide dummy implementations for !x86 arches.

I do not see why, the code is already protected by x86 checks.

Convert vt_vga.c to use acpi_get_fadt_bootflags().

Also initialize ignore before TUNABLE_INT_FETCH(). Otherwise, if there is no kenv var, the local is uninitialized.

LGTM thanks.

sys/dev/vt/hw/vga/vt_vga.c
51

Not sure if it's a phab issue, but I think the last defined is missing the closing ')'. ie: defined(__i386__)

This revision is now accepted and ready to land.Jun 25 2018, 10:24 AM
This revision was automatically updated to reflect the committed changes.
kib updated this revision to Diff 44415.

The rest of the patch.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 25 2018, 11:24 AM
This revision was automatically updated to reflect the committed changes.