Page MenuHomeFreeBSD
Differential D16004

Do not access ISA timer if BIOS reports that there is no legacy devices present.
ClosedPublic
Actions

Authored by kib on Jun 25 2018, 9:29 AM.
Tags
None
Referenced Files
F165281338: D16004.id44415.diff
Fri, Aug 7, 9:36 AM
F165239150: D16004.id44410.diff
Fri, Aug 7, 2:21 AM
F165236825: D16004.id44414.diff
Fri, Aug 7, 2:01 AM
F165186849: D16004.id44410.diff
Thu, Aug 6, 2:53 PM
F165177695: D16004.id44414.diff
Thu, Aug 6, 2:14 PM
Unknown Object (File)
Thu, Aug 6, 12:59 PM
Unknown Object (File)
Thu, Aug 6, 8:26 AM
Unknown Object (File)
Wed, Aug 5, 7:57 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
royger
Commits
rS335634: Do not access ISA timer if BIOS reports that there is no legacy
rS335632: Provide a helper function acpi_get_fadt_bootflags() to fetch the FADT
rS335631: Always initialize the ignore local variable.
Summary

I did not committed this because on the computer where ISA timer is gated, bios really reports that ISA devices are present.
But I think now that acpi_get_fadt_bootflags() is useful on its own.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 17604

Event Timeline

kib created this revision.Jun 25 2018, 9:29 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 25 2018, 9:29 AM
Harbormaster completed remote builds in B17604: Diff 44410.Jun 25 2018, 9:29 AM
kib edited the summary of this revision. (Show Details)Jun 25 2018, 9:30 AM
kib mentioned this in D16003: vt: add option to ignore NO_VGA flag in ACPI.
royger added a comment.Jun 25 2018, 9:35 AM

I would like to use acpi_get_fadt_bootflags for vt also, but then it needs to live in some generic ACPI file, or else I would have to provide dummy implementations for !x86 arches.

kib added a comment.Jun 25 2018, 10:16 AM
In D16004#338788, @royger wrote:

I would like to use acpi_get_fadt_bootflags for vt also, but then it needs to live in some generic ACPI file, or else I would have to provide dummy implementations for !x86 arches.

I do not see why, the code is already protected by x86 checks.

kib updated this revision to Diff 44413.Jun 25 2018, 10:18 AM

Convert vt_vga.c to use acpi_get_fadt_bootflags().

Also initialize ignore before TUNABLE_INT_FETCH(). Otherwise, if there is no kenv var, the local is uninitialized.

royger accepted this revision.Jun 25 2018, 10:24 AM

LGTM thanks.

sys/dev/vt/hw/vga/vt_vga.c
51 ↗(On Diff #44413)

Not sure if it's a phab issue, but I think the last defined is missing the closing ')'. ie: defined(__i386__)

This revision is now accepted and ready to land.Jun 25 2018, 10:24 AM
Closed by commit rS335631: Always initialize the ignore local variable. (authored by kib). · Explain WhyJun 25 2018, 10:53 AM
This revision was automatically updated to reflect the committed changes.
kib reopened this revision.Jun 25 2018, 11:03 AM
kib updated this revision to Diff 44415.

The rest of the patch.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 25 2018, 11:24 AM
Closed by commit rS335634: Do not access ISA timer if BIOS reports that there is no legacy (authored by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
x86/
include/
1 line
isa/
26 lines
x86/
23 lines
26 lines

Diff 44410

View Options

sys/x86/include/x86_var.h

Loading...
View Options

sys/x86/isa/atrtc.c

Loading...
View Options

sys/x86/x86/cpu_machdep.c

Loading...
View Options

sys/x86/x86/tsc.c

Loading...