Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 17526 Build 17349: arc lint + arc unit
Event Timeline
Comment Actions
This is fine.
Since you are changing the line, I believe two additional bugs should be fixed. long is the wrong type to use, uintptr_t is correct. Also please do the explicit comparision with 0, since the result of and is not boolean:
if (((uintptr_t)dp & 0x7) != 0) break;
Comment Actions
As I said I believe it is fine functionally.
One note I have about it is that the change makes libc incompatible with pre-ino64 kernel. IMO this is fine, but note that other people do not agree. In particular, I think that imp' forward-compat shims for the ino64-changed syscalls are now less useful.
If you consider this important enough, you can do something like this:
... & (__getosreldate() >= INO64_FIRST ? 0x7 : 0x3)) != 0)