update proc->p_ptevents annotation
ClosedPublic
Actions

Authored by yanko.yankulov_gmail.com on Jun 21 2018, 4:55 PM.

Tags

None

Referenced Files

	F167718513: D15954.id44262.diff
	Sun, Aug 23, 11:46 PM

	Unknown Object (File)
	Sun, Aug 23, 11:45 AM

	Unknown Object (File)
	Sun, Aug 23, 5:12 AM

	Unknown Object (File)
	Sat, Aug 22, 2:01 PM

	Unknown Object (File)
	Fri, Aug 21, 3:10 PM

	Unknown Object (File)
	Fri, Aug 21, 1:12 PM

	Unknown Object (File)
	Thu, Aug 20, 8:34 PM

	Unknown Object (File)
	Thu, Aug 20, 2:21 PM

View All Files

Subscribers

imp

Details

Reviewers

kib
jhb

Commits

rS335503: Update proc->p_ptevents annotation to reflect the actual locking.

Summary

So it reflects the actual use

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

yanko.yankulov_gmail.com created this revision.Jun 21 2018, 4:55 PM

yanko.yankulov_gmail.com added a child revision: D15857: fork: avoid endless wait with PTRACE_FORK and RFSTOPPED.

kib accepted this revision.Jun 21 2018, 5:25 PM

kib added a reviewer: jhb.

kib added inline comments.

sys/kern/sys_process.c
690	The blank line is intended. There must be the blank line after the locals, even if the locals block is empty.

This revision is now accepted and ready to land.Jun 21 2018, 5:25 PM

With @kib's requested style fix.

Restore the wrongfully deleted empty line.

This revision now requires review to proceed.Jun 21 2018, 6:52 PM

jhb accepted this revision.Jun 21 2018, 7:00 PM

This revision is now accepted and ready to land.Jun 21 2018, 7:00 PM

Closed by commit rS335503: Update proc->p_ptevents annotation to reflect the actual locking. (authored by kib). · Explain WhyJun 21 2018, 9:07 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 21 2018, 9:07 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

sys_process.c

1 line

sys/

proc.h

2 lines

Diff 44252

View Options

sys/kern/sys_process.c