Page MenuHomeFreeBSD
Differential D1050

Implement prlimit64() system call.
ClosedPublic
Actions

Authored by dchagin on Oct 31 2014, 6:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 4:10 AM
Unknown Object (File)
Wed, Dec 18, 3:22 AM
Unknown Object (File)
Nov 12 2024, 10:18 PM
Unknown Object (File)
Nov 1 2024, 5:45 AM
Unknown Object (File)
Nov 1 2024, 5:13 AM
Unknown Object (File)
Oct 20 2024, 1:23 AM
Unknown Object (File)
Oct 14 2024, 11:52 PM
Unknown Object (File)
Oct 1 2024, 8:28 PM
View All Files
Subscribers
imp
trasz

Details

Reviewers
emaste
trasz
Group Reviewers
Linux Emulation
Commits
rS283401: Implement prlimit64() system call.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

dchagin updated this revision to Diff 2180.Oct 31 2014, 6:48 AM
dchagin retitled this revision from to Implement prlimit64() system call..
dchagin added a reviewer: Linux Emulation.Oct 31 2014, 6:59 AM
emaste accepted this revision.Oct 31 2014, 1:42 PM
emaste added a reviewer: emaste.
This revision is now accepted and ready to land.Oct 31 2014, 1:42 PM
dchagin updated this revision to Diff 4375.Mar 24 2015, 5:51 PM
dchagin edited edge metadata.

style(9)

This revision now requires review to proceed.Mar 24 2015, 5:51 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 24 2015, 5:51 PM
trasz added a subscriber: trasz.Mar 25 2015, 11:39 AM
trasz added inline comments.
sys/amd64/linux32/syscalls.master
559

const? Also, FreeBSD rlim_t is int64, while Linux 'struct rlimit64' seems to have uint64 there.

Same thing below.

dchagin updated this revision to Diff 4411.Mar 25 2015, 6:00 PM
dchagin edited edge metadata.

Add a note about rlim signedness.

About const - I would prefer to not use 'const' in masters,
thereto clang complains to discard qualifers in copyout()

dchagin updated this revision to Diff 4413.Mar 25 2015, 6:17 PM

I'm wrong, we do not conversion for new limits, but we should convert RLIM_INFINITY.

trasz added a comment.Mar 27 2015, 11:52 AM

Erm, what exactly does the clang say? I mean, in copyout(9) declaration there is a "const" for the kernel pointer, so it shouldn't complain about it?

trasz accepted this revision.Mar 27 2015, 11:58 AM
trasz added a reviewer: trasz.

I'd prefer explicit conversion - even if it's just memcpy in one of the directions - but it's ok for now.

This revision is now accepted and ready to land.Mar 27 2015, 11:58 AM
trasz requested changes to this revision.Mar 27 2015, 12:02 PM
trasz edited edge metadata.

Erm, wait. You're missing access check before kern_proc_setrlimit(). I _think_ it should be PGET_CANDEBUG (as opposed to PGET_CANSEE for retrieving limits); that's what sysctl_kern_proc_rlimit() uses.

This revision now requires changes to proceed.Mar 27 2015, 12:02 PM
dchagin updated this revision to Diff 4476.Mar 28 2015, 8:47 AM
dchagin edited edge metadata.

Yes, yoa are right! I was thinking why kern_proc_setrlimit()
does not check access. ie, sys_setrlimit.

fixed by copiyng code fro, sysctl code, thnak you very match!

dchagin updated this revision to Diff 4491.Mar 29 2015, 4:48 AM
dchagin edited edge metadata.

typo fixed.

trasz added inline comments.Mar 31 2015, 12:13 PM
sys/compat/linux/linux_misc.c
2084

Does it still do the same thing for PID 0?

Closed by commit rS283401: Implement prlimit64() system call. (authored by dchagin). · Explain WhyMay 24 2015, 3:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux32/
2 lines
5 lines
compat/
linux/
65 lines
i386/
linux/
2 lines
5 lines

Diff 4411

View Options

sys/amd64/linux32/linux32_dummy.c

Loading...
View Options

sys/amd64/linux32/syscalls.master

Loading...
View Options

sys/compat/linux/linux_misc.c

Loading...
View Options

sys/i386/linux/linux_dummy.c

Loading...
View Options

sys/i386/linux/syscalls.master

Loading...