Differential D15915

Fix sources needed for lld.
ClosedPublic
Actions

Authored by bdrewery on Jun 19 2018, 11:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 15, 4:18 AM

	Unknown Object (File)
	Sat, Aug 15, 4:18 AM

	Unknown Object (File)
	Sat, Aug 15, 4:18 AM

	Unknown Object (File)
	Sat, Aug 15, 4:17 AM

	Unknown Object (File)
	Thu, Aug 13, 6:20 AM

	Unknown Object (File)
	Thu, Aug 13, 6:20 AM

	Unknown Object (File)
	Thu, Aug 13, 6:20 AM

	Unknown Object (File)
	Thu, Aug 13, 6:20 AM

Subscribers

Details

Reviewers

dim
emaste

Commits

rS335449: Fix sources needed for lld.

Summary

lld always needs these DWARF sources, as well as other default and extra
tools. XDL seems to be the best fit list.

Remove MK_LLD_IS_LD check from SRCS_MIW which is now reduced to just a
few files for llvm-objdump.

Sponsored by: Dell EMC

Test Plan

local builds
I removed all of these from the lld build and added one at a time until it passed to determine this list.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17461
Build 17291: arc lint + arc unit

Event Timeline

bdrewery created this revision.Jun 19 2018, 11:29 PM

Harbormaster completed remote builds in B17461: Diff 44107.Jun 19 2018, 11:29 PM

bdrewery added a child revision: D15894: Add WITH_SYSTEM_LINKER, on by default, that avoids building lld when possible..Jun 19 2018, 11:30 PM

bdrewery mentioned this in D15837: Rework WITHOUT_LLD/TOOLCHAIN fix from r327892 for cross-tools..

bdrewery edited the test plan for this revision. (Show Details)Jun 19 2018, 11:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 20 2018, 4:10 PM

Closed by commit rS335449: Fix sources needed for lld. (authored by bdrewery). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 20 2018, 4:10 PM

dim mentioned this in rS360667: MFC r330366 (by emaste):.May 5 2020, 6:44 PM

Revision Contents
Changeset List

Path

Size

lib/

clang/

libllvm/

50 lines

Diff 44107

lib/clang/libllvm/Makefile

Loading...