Page MenuHomeFreeBSD
Differential D15882

net/subnetcalc: update to 2.4.9
ClosedPublic
Actions

Authored by fernape on Jun 18 2018, 3:12 PM.
Tags
None
Referenced Files
F126383180: D15882.diff
Mon, Aug 18, 5:17 PM
F126379758: D15882.diff
Mon, Aug 18, 4:10 PM
Unknown Object (File)
Fri, Aug 15, 12:35 PM
Unknown Object (File)
Mon, Aug 11, 12:54 PM
Unknown Object (File)
Sat, Aug 9, 2:17 PM
Unknown Object (File)
Tue, Jul 29, 1:59 AM
Unknown Object (File)
Mon, Jul 28, 10:16 PM
Unknown Object (File)
Mon, Jul 28, 7:37 PM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
tz
Commits
rP473848: net/subnetcalc: update to 2.4.9
Summary

Sent by freebsd_ports@k-worx.org in PR 229108

Awaiting maintainer (dreibh@iem.uni-due.de) approval

Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • run test in 10.4 amd64 OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 17456
Build 17287: arc lint + arc unit

Event Timeline

fernape created this revision.Jun 18 2018, 3:12 PM
Herald added a subscriber: mat. · View Herald TranscriptJun 18 2018, 3:12 PM
Harbormaster completed remote builds in B17407: Diff 44005.Jun 18 2018, 3:12 PM
tcberner requested changes to this revision.Jun 18 2018, 6:03 PM
tcberner added inline comments.
net/subnetcalc/Makefile
17–18

^prefer cmake:outsource if it works

23

^ you should be able to just set CMAKE_INSTALL_MANDIR to something sensible instead of patching.

This revision now requires changes to proceed.Jun 18 2018, 6:03 PM
fernape updated this revision to Diff 44084.Jun 19 2018, 5:13 PM
  • Use outsource building
  • Use CMAKE_INSTALL_MANDIR* variables instead of post-patch
Harbormaster completed remote builds in B17449: Diff 44084.Jun 19 2018, 5:13 PM
tcberner added inline comments.Jun 19 2018, 5:43 PM
net/subnetcalc/Makefile
18

^once should be enough :) -- also, use "\" to break the line, and not add CMAKE_ARGS+= -- makes it more readable.

fernape updated this revision to Diff 44099.Jun 19 2018, 8:11 PM
  • Set DCMAKE_INSTALL_MANDIR only
Harbormaster completed remote builds in B17456: Diff 44099.Jun 19 2018, 8:11 PM
tcberner accepted this revision.Jun 21 2018, 4:39 PM
This revision is now accepted and ready to land.Jun 21 2018, 4:39 PM
Closed by commit rP473848: net/subnetcalc: update to 2.4.9 (authored by fernape). · Explain WhyJul 3 2018, 5:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
net/
subnetcalc/
8 lines
6 lines

Diff 44099

View Options

net/subnetcalc/Makefile

Loading...
View Options

net/subnetcalc/distinfo

Loading...