Page MenuHomeFreeBSD
Differential D15836

Rework how the ld link is handled in WORLDTMP from r322811.
ClosedPublic
Actions

Authored by bdrewery on Jun 15 2018, 10:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 30, 3:24 PM
Unknown Object (File)
Sat, Nov 30, 3:24 PM
Unknown Object (File)
Sat, Nov 30, 3:24 PM
Unknown Object (File)
Sat, Nov 30, 3:24 PM
Unknown Object (File)
Sat, Nov 30, 3:10 PM
Unknown Object (File)
Nov 22 2024, 2:09 AM
Unknown Object (File)
Nov 22 2024, 2:09 AM
Unknown Object (File)
Nov 22 2024, 2:09 AM
View All 56 Files
Subscribers
imp

Details

Reviewers
dim
emaste
Commits
rS360667: MFC r330366 (by emaste):
rS335447: Rework how the ld link is handled in WORLDTMP from r322811.
Summary

LLD_BOOTSTRAP (build) is independent of LLD_IS_LD (installed) so they
should not be based on each other.

This is related to upcoming WITH_SYSTEM_LINKER work.

Sponsored by: Dell EMC

Test Plan

Did various WITHOUT_LLD and WITHOUT_LLD_IS_LD tests (with WITH_LLD_BOOTSTRAP set)

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17431
Build 17263: arc lint + arc unit

Event Timeline

bdrewery created this revision.Jun 15 2018, 10:36 PM
Harbormaster completed remote builds in B17320: Diff 43854.Jun 15 2018, 10:36 PM
bdrewery added inline comments.Jun 15 2018, 10:38 PM
gnu/usr.bin/binutils/ld/Makefile
11

This is not strictly needed for make buildworld but DIRDEPS_BUILD actually will complain if 2 ld.1 files get installed.

emaste added inline comments.Jun 16 2018, 7:52 PM
usr.bin/clang/lld/Makefile
12

We really need some documentation for the magic TOOLS_PREFIX tests

bdrewery added inline comments.Jun 18 2018, 6:47 PM
usr.bin/clang/lld/Makefile
12

All it really means is that it is in the 'cross-tools' phase of buildworld and is building a cross-toolchain for the build only.

bdrewery added a child revision: D15894: Add WITH_SYSTEM_LINKER, on by default, that avoids building lld when possible..Jun 19 2018, 1:18 AM
emaste added inline comments.Jun 19 2018, 1:31 AM
usr.bin/clang/lld/Makefile
12

Doesn't this one need (!defined(TOOLS_PREFIX && ...) || (defined(TOOLS_PREFIX) && ...) like the other case?

bdrewery updated this revision to Diff 44053.Jun 19 2018, 1:53 AM

Reduce duplicated logic and add missing check on TOOLS_PREFIX.

Harbormaster completed remote builds in B17431: Diff 44053.Jun 19 2018, 1:53 AM
bdrewery marked an inline comment as done.Jun 19 2018, 1:53 AM
emaste added a comment.Jun 19 2018, 2:27 AM

LGTM

emaste accepted this revision.Jun 19 2018, 2:27 AM
This revision is now accepted and ready to land.Jun 19 2018, 2:27 AM
Closed by commit rS335447: Rework how the ld link is handled in WORLDTMP from r322811. (authored by bdrewery). · Explain WhyJun 20 2018, 4:10 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJun 20 2018, 4:10 PM
dim added a commit: rS360667: MFC r330366 (by emaste):.May 5 2020, 6:44 PM

Revision Contents
Changeset List

PathSize
2 lines
gnu/
usr.bin/
binutils/
ld/
7 lines
usr.bin/
clang/
lld/
3 lines

Diff 44053

View Options

Makefile.inc1

Loading...
View Options

gnu/usr.bin/binutils/ld/Makefile

Loading...
View Options

usr.bin/clang/lld/Makefile

Loading...