Differential D15763

powerpc64: Avoid type promotion
ClosedPublic
Actions

Authored by breno.leitao_gmail.com on Jun 11 2018, 7:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 27, 5:07 PM

	Unknown Object (File)
	Tue, Apr 21, 11:12 AM

	Unknown Object (File)
	Sat, Apr 18, 5:53 PM

	Unknown Object (File)
	Sat, Apr 18, 3:39 PM

	Unknown Object (File)
	Sat, Apr 18, 3:39 PM

	Unknown Object (File)
	Sat, Apr 18, 3:38 PM

	Unknown Object (File)
	Sat, Apr 18, 3:38 PM

	Unknown Object (File)
	Sat, Apr 18, 1:55 PM

Subscribers

Details

Reviewers

wma
jhibbits

Commits

rS335013: powerpc64/powernv: Avoid type promotion

Summary

There is a type promotion that transform count = -1 into a unsigned int causing
the default TCE SEG SIZE not being returned on a Boston POWER9 machine.
This machine does not have the 'ibm,supported-tce-sizes' entries, thus, count
is set to -1, and the function continue to execute instead of returning.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

breno.leitao_gmail.com created this revision.Jun 11 2018, 7:27 PM

Herald added a subscriber: jhibbits. · View Herald TranscriptJun 11 2018, 7:27 PM

Harbormaster completed remote builds in B17176: Diff 43614.Jun 11 2018, 7:27 PM

Better approach forcing promotion.

Harbormaster completed remote builds in B17177: Diff 43616.Jun 11 2018, 7:53 PM

breno.leitao_gmail.com added reviewers: wma, jhibbits.Jun 11 2018, 7:54 PM

This can be simplified to just "if (count < (int)sizeof(cell_t))"

Adjusting to follow jhibbits' suggestion.

Harbormaster completed remote builds in B17183: Diff 43623.Jun 11 2018, 9:41 PM

wma added inline comments.Jun 12 2018, 4:34 AM

sys/powerpc/powernv/opal_pci.c
224 ↗	(On Diff #43623)	Looks good, except the semicolon at the end ;)

Fixing silly error.

Harbormaster completed remote builds in B17199: Diff 43652.Jun 12 2018, 1:00 PM

jhibbits accepted this revision.Jun 12 2018, 6:45 PM

This revision is now accepted and ready to land.Jun 12 2018, 6:45 PM

Closed by commit rS335013: powerpc64/powernv: Avoid type promotion (authored by leitao). · Explain WhyJun 12 2018, 7:50 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 12 2018, 7:50 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

powernv/

2 lines

Diff 43668

head/sys/powerpc/powernv/opal_pci.c

Loading...