Differential D15763

powerpc64: Avoid type promotion
ClosedPublic
Actions

Authored by breno.leitao_gmail.com on Jun 11 2018, 7:27 PM.

Tags

None

Referenced Files

	F152160121: D15763.id43616.diff
	Mon, Apr 13, 3:42 AM

	F152088248: D15763.diff
	Sun, Apr 12, 3:52 PM

	Unknown Object (File)
	Fri, Apr 10, 7:24 AM

	Unknown Object (File)
	Thu, Apr 9, 1:23 PM

	Unknown Object (File)
	Thu, Apr 9, 4:55 AM

	Unknown Object (File)
	Tue, Apr 7, 2:58 AM

	Unknown Object (File)
	Fri, Apr 3, 1:01 AM

	Unknown Object (File)
	Fri, Mar 27, 12:53 PM

Subscribers

Details

Reviewers

wma
jhibbits

Commits

rS335013: powerpc64/powernv: Avoid type promotion

Summary

There is a type promotion that transform count = -1 into a unsigned int causing
the default TCE SEG SIZE not being returned on a Boston POWER9 machine.
This machine does not have the 'ibm,supported-tce-sizes' entries, thus, count
is set to -1, and the function continue to execute instead of returning.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17177
Build 17029: arc lint + arc unit

Event Timeline

breno.leitao_gmail.com created this revision.Jun 11 2018, 7:27 PM

Herald added a subscriber: jhibbits. · View Herald TranscriptJun 11 2018, 7:27 PM

Harbormaster completed remote builds in B17176: Diff 43614.Jun 11 2018, 7:27 PM

Better approach forcing promotion.

Harbormaster completed remote builds in B17177: Diff 43616.Jun 11 2018, 7:53 PM

breno.leitao_gmail.com added reviewers: wma, jhibbits.Jun 11 2018, 7:54 PM

This can be simplified to just "if (count < (int)sizeof(cell_t))"

Adjusting to follow jhibbits' suggestion.

Harbormaster completed remote builds in B17183: Diff 43623.Jun 11 2018, 9:41 PM

wma added inline comments.Jun 12 2018, 4:34 AM

sys/powerpc/powernv/opal_pci.c
225–227	Looks good, except the semicolon at the end ;)

Fixing silly error.

Harbormaster completed remote builds in B17199: Diff 43652.Jun 12 2018, 1:00 PM

jhibbits accepted this revision.Jun 12 2018, 6:45 PM

This revision is now accepted and ready to land.Jun 12 2018, 6:45 PM

Closed by commit rS335013: powerpc64/powernv: Avoid type promotion (authored by leitao). · Explain WhyJun 12 2018, 7:50 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 12 2018, 7:50 PM

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

powernv/

5 lines

Diff 43616

sys/powerpc/powernv/opal_pci.c

Loading...