Details
Details
- Reviewers
tcberner - Group Reviewers
Contributor Reviewers (ports) - Commits
- rP472633: math/cryptominisat and math/py-cryptominisat: Update to 5.6.1.
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 17170 Build 17022: arc lint + arc unit
Event Timeline
| math/cryptominisat/Makefile | ||
|---|---|---|
| 4 | ^ you could switch this to DISTVERSION | |
| 24–25 | ^ think about switching to cmake:outsource while you're here | |
| 25–26 | CMAKE_ON= NOM4RI CMAKE_OFF= ENABLE_PYTHON_INTERFACE is maybe a bit more readable. | |
| math/py-cryptominisat/Makefile | ||
| 4 | ^ same here | |
| math/py-cryptominisat/files/patch-setup.py.in | ||
| 9 | Why is this change needed, ... ah, because you're not using cmake anymore here. You should probably reinplace ${CC} instead of using 'cc' directly in the patch. | |
Comment Actions
You could also think about making the python one a slave of the other while you're here.
| math/cryptominisat/Makefile | ||
|---|---|---|
| 16–17 | This is not needed. | |
| 19–20 | Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. | |
| 22–23 | Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. | |
| math/py-cryptominisat/Makefile | ||
| 18 | Python 2.6 was removed 4 and a half years ago, you could s/-2.7/2.7/. | |
| math/py-cryptominisat/Makefile | ||
|---|---|---|
| 29–35 | Is there a reason to run sed 6 times instead of just once? | |