Quiet coretemp probe
ClosedPublic
Actions

Authored by kbowling on Jun 10 2018, 1:35 AM.

Tags

None

Referenced Files

	F106213474: D15727.diff
	Fri, Dec 27, 7:14 AM

	Unknown Object (File)
	Thu, Dec 26, 5:52 PM

	Unknown Object (File)
	Thu, Dec 26, 2:59 PM

	Unknown Object (File)
	Thu, Dec 26, 9:08 AM

	Unknown Object (File)
	Sat, Dec 21, 7:52 AM

	Unknown Object (File)
	Thu, Nov 28, 4:49 AM

	Unknown Object (File)
	Nov 13 2024, 6:32 PM

	Unknown Object (File)
	Oct 9 2024, 7:00 AM

View All 49 Files

Subscribers

imp

Details

Reviewers

mmacy
sbruno
imp

Commits

rS335186: Quiet coretemp probe

Summary

Only the first device will print
coretemp0: <CPU On-Die Thermal Sensors> numa-domain 0 on cpu0
instead of all hyper threads

I thought about printing once per package but there is no simple way to do that and I'm not sure the complexity is worth it

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling created this revision.Jun 10 2018, 1:35 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 10 2018, 1:35 AM

I'm surprised we need this since I set all CPUs to quiet children if they aren't CPU0.

sys/dev/coretemp/coretemp.c
150	This is similar to a change that I made to the CPU code.... But the CPU code had device_set_quiet_children that I thought would have taken care of this...

This revision is now accepted and ready to land.Jun 10 2018, 1:51 AM

sbruno accepted this revision.Jun 12 2018, 7:46 PM

Closed by commit rS335186: Quiet coretemp probe (authored by mmacy). · Explain WhyJun 15 2018, 2:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

coretemp/

coretemp.c

3 lines

Diff 43532

View Options

sys/dev/coretemp/coretemp.c

Quiet coretemp probeClosedPublicActions