Page MenuHomeFreeBSD
Differential D14818

lualoader: Add cli.lua(8) to the tree
ClosedPublic
Actions

Authored by kevans on Mar 24 2018, 3:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 10, 3:35 AM
Unknown Object (File)
Sun, Nov 9, 8:45 PM
Unknown Object (File)
Sun, Nov 9, 4:50 PM
Unknown Object (File)
Sun, Nov 9, 12:54 PM
Unknown Object (File)
Tue, Nov 4, 9:01 AM
Unknown Object (File)
Mon, Nov 3, 11:27 PM
Unknown Object (File)
Sat, Nov 1, 1:23 PM
Unknown Object (File)
Sat, Nov 1, 1:23 PM
View All Files
Subscribers
imp

Details

Reviewers
rpokala
Group Reviewers
manpages
Commits
rS334891: lualoader: Add cli.lua(8) to the tree

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 17114

Event Timeline

kevans created this revision.Mar 24 2018, 3:47 AM
Herald added a reviewer: manpages. · View Herald TranscriptMar 24 2018, 3:47 AM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B15759: Diff 40670.Mar 24 2018, 3:47 AM
kevans added a comment.Mar 24 2018, 3:50 AM

I'm leaving cli_execute and cli_execute_unparsed undocumented for the time being, since they're:

1.) Kind of special kittens
2.) Actually global
3.) Less stable API

rpokala requested changes to this revision.Jun 8 2018, 3:48 AM
rpokala added inline comments.
stand/lua/cli.lua.8
6

Per discussions over the last few months, remove "All rights reserved."

39

"... commands, which can be executed at ..."

60

s/of/off/

79

The example function is cli.foo, but this says Foo -- capitalized. Is that intended?

97

This -width value looks like a holdover from another manpage that you derived this from.

This revision now requires changes to proceed.Jun 8 2018, 3:48 AM
kevans updated this revision to Diff 43491.Jun 9 2018, 2:30 PM

I believe I've addressed your latest concerns. =)

Harbormaster completed remote builds in B17114: Diff 43491.Jun 9 2018, 2:30 PM
rpokala accepted this revision as: rpokala.Jun 9 2018, 6:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 9 2018, 7:51 PM
Closed by commit rS334891: lualoader: Add cli.lua(8) to the tree (authored by kevans). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stand/
lua/
112 lines

Diff 43491

View Options

stand/lua/cli.lua.8

Loading...