auto-admin: Add support for AD authentication, factor out pkgsrc scripts
ClosedPublic
Actions

Authored by jwb on May 30 2018, 4:47 PM.

Details

Reviewers

jrm
wen

Commits

rP471149: auto-admin: Add support for AD authentication, factor out pkgsrc scripts

Summary

auto-admin: Add support for AD authentication, factor out pkgsrc scripts
Approved by jrm (mentor) or wen (mentor)
Differential to be added to commit message

Test Plan

portlint -AC: looks fine
Tested in production

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 16918
Build 16795: arc lint + arc unit

Event Timeline

jwb created this revision.May 30 2018, 4:47 PM

Herald added a subscriber: mat. · View Herald TranscriptMay 30 2018, 4:47 PM

Harbormaster completed remote builds in B16912: Diff 43144.May 30 2018, 4:47 PM

jrm added inline comments.May 30 2018, 5:02 PM

sysutils/auto-admin/Makefile
19	Could silence the MKDIR? It's the one install target command we are prejudiced against (so I am told).
24–25	Is this correct? I didn't test, but it looks like it is installing the same file over each interation, but with a different name.

Silence mkdir

Harbormaster completed remote builds in B16914: Diff 43149.May 30 2018, 5:12 PM

Yes, it's correct. Currently there is one man page covering all scripts (at least the ones that are documented).

jrm accepted this revision.May 30 2018, 5:28 PM

This revision is now accepted and ready to land.May 30 2018, 5:28 PM

mat added inline comments.May 30 2018, 5:37 PM

sysutils/auto-admin/Makefile
24–25	You should probably not install the same man-page over and over again but create symlinks. ${RLN} ${STAGEDIR}${MANPREFIX}/man/man1/auto-admin.1 ${STAGEDIR}${MANPREFIX}/man/man1/`basename $${name}`.1;

Better yet, I'm just going to stop generating manpages for undocumented
scripts. I need to catch up on the documentation as well as separate it out.
I'd like to autogenerate man pages for each script, but haven't found a good
tool yet. Doxygen is nice for HTML but stinks at man pages.

This revision now requires review to proceed.May 30 2018, 6:32 PM

Harbormaster completed remote builds in B16918: Diff 43155.May 30 2018, 6:32 PM

LGTM.

P.S. You can mark inline comments as Done. The interface is a little special. After you mark them, you have to hit submit at the bottom.

This revision is now accepted and ready to land.May 30 2018, 6:35 PM

Closed by commit rP471149: auto-admin: Add support for AD authentication, factor out pkgsrc scripts (authored by jwb). · Explain WhyMay 30 2018, 6:48 PM

This revision was automatically updated to reflect the committed changes.

jwb marked an inline comment as done.

Yeah, I knew about the done box. Sorry, just distracted today.