Page MenuHomeFreeBSD

auto-admin: Add support for AD authentication, factor out pkgsrc scripts
ClosedPublic

Authored by jwb on May 30 2018, 4:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 23 2024, 5:07 AM
Unknown Object (File)
Feb 23 2024, 5:07 AM
Unknown Object (File)
Feb 23 2024, 5:04 AM
Unknown Object (File)
Feb 23 2024, 5:04 AM
Unknown Object (File)
Feb 23 2024, 5:04 AM
Unknown Object (File)
Feb 22 2024, 5:04 PM
Unknown Object (File)
Dec 23 2023, 12:53 PM
Unknown Object (File)
Dec 23 2023, 12:53 PM
Subscribers

Details

Summary

auto-admin: Add support for AD authentication, factor out pkgsrc scripts
Approved by jrm (mentor) or wen (mentor)
Differential to be added to commit message

Test Plan

portlint -AC: looks fine
Tested in production

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 16912
Build 16789: arc lint + arc unit

Event Timeline

sysutils/auto-admin/Makefile
19

Could silence the MKDIR? It's the one install target command we are prejudiced against (so I am told).

26

Is this correct? I didn't test, but it looks like it is installing the same file over each interation, but with a different name.

Yes, it's correct. Currently there is one man page covering all scripts (at least the ones that are documented).

This revision is now accepted and ready to land.May 30 2018, 5:28 PM
sysutils/auto-admin/Makefile
26

You should probably not install the same man-page over and over again but create symlinks.

${RLN} ${STAGEDIR}${MANPREFIX}/man/man1/auto-admin.1   ${STAGEDIR}${MANPREFIX}/man/man1/`basename $${name}`.1;

Better yet, I'm just going to stop generating manpages for undocumented
scripts. I need to catch up on the documentation as well as separate it out.
I'd like to autogenerate man pages for each script, but haven't found a good
tool yet. Doxygen is nice for HTML but stinks at man pages.

This revision now requires review to proceed.May 30 2018, 6:32 PM

LGTM.

P.S. You can mark inline comments as Done. The interface is a little special. After you mark them, you have to hit submit at the bottom.

This revision is now accepted and ready to land.May 30 2018, 6:35 PM
This revision was automatically updated to reflect the committed changes.
jwb marked an inline comment as done.
jwb marked 2 inline comments as done.May 30 2018, 6:49 PM

Yeah, I knew about the done box. Sorry, just distracted today.