Page MenuHomeFreeBSD

Update devel/kdevelop, devel/kdev-python and devel/kdev-php to 5.2.3.
ClosedPublic

Authored by arrowd on May 28 2018, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 1:42 PM
Unknown Object (File)
Wed, Apr 17, 11:25 AM
Unknown Object (File)
Jan 31 2024, 5:00 PM
Unknown Object (File)
Dec 20 2023, 12:25 AM
Unknown Object (File)
Oct 27 2023, 8:37 PM
Unknown Object (File)
Oct 27 2023, 8:37 PM
Unknown Object (File)
Oct 27 2023, 8:37 PM
Unknown Object (File)
Oct 27 2023, 3:22 PM
Subscribers
None

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 16887
Build 16764: arc lint + arc unit

Event Timeline

You should add kde as a group reviewer too :)

devel/kdevelop/Makefile
21

^ I think you need to add some cmake flag/patch so that i only picks up llvm60, as it checks against multiple versions, it could be, possibly, that it would use llvm50 if that is also installed.

devel/kdevelop/pkg-plist
373

^ this is probably an existing error in the plist -- and os supposed to be
lib/cmake/KDevPlatform/KDevPlatformTargets-release.cmake

unless it is indeed
lib/cmake/KDevPlatform/KDevPlatformTargets-debug.cmake when having WITH_DEBUG set.

devel/kdevelop/Makefile
21

Judging from FindLLVM.cmake/FindClang.cmake, it starts searching from a newest version. And since llvm60 is now guaranteed to be pulled in as dependency, I think there is no need in explicit setting of LLVM version in Makefile.

devel/kdevelop/pkg-plist
373

Yep, it is debug when building WITH_DEBUG=1.

Great, in that case, go ahead :)

This revision is now accepted and ready to land.May 29 2018, 5:06 PM
This revision was automatically updated to reflect the committed changes.