Page MenuHomeFreeBSD
Differential D15573

New Port: editors/gomate
ClosedPublic
Actions

Authored by fabian.freyer_physik.tu-berlin.de on May 25 2018, 3:43 PM.
Tags
None
Referenced Files
F163484730: D15573.id42992.diff
Thu, Jul 23, 4:16 PM
F163474065: D15573.id42992.diff
Thu, Jul 23, 12:54 PM
Unknown Object (File)
Thu, Jul 23, 7:16 AM
Unknown Object (File)
Thu, Jul 23, 5:56 AM
Unknown Object (File)
Thu, Jul 23, 2:18 AM
Unknown Object (File)
Thu, Jul 23, 1:20 AM
Unknown Object (File)
Wed, Jul 22, 3:33 PM
Unknown Object (File)
Wed, Jul 22, 2:04 PM
View All Files
Subscribers
mat
tobik
Contributor Reviewers (ports)

Details

Reviewers
tobik
Commits
rP470882: New port: editors/gomate
Summary

New port for gomate.

See PR 228486

Test Plan

tested port with poudriere testport, smoke-tested functionality

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

fabian.freyer_physik.tu-berlin.de created this revision.May 25 2018, 3:43 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptMay 25 2018, 3:43 PM
fabian.freyer_physik.tu-berlin.de edited the summary of this revision. (Show Details)May 25 2018, 3:49 PM
tobik added a subscriber: tobik.May 25 2018, 4:09 PM
tobik added inline comments.
editors/gomate/pkg-descr
2

Gomate is an implementation of [...]. It allows editing of files [...]

4

s/the //

editors/gomate/pkg-message
2

Remove this line. It doesn't add any useful information.

4–6

To remotely edit a file on this host connect via SSH with remote port forwarding:

(I don't think it's useful to repeat pkg-descr here.)

fabian.freyer_physik.tu-berlin.de updated this revision to Diff 42995.May 25 2018, 4:15 PM

adressed @tobik's comments

fabian.freyer_physik.tu-berlin.de marked 3 inline comments as done.May 25 2018, 4:15 PM
tobik added inline comments.May 25 2018, 4:20 PM
editors/gomate/pkg-descr
2

s/edititing/editing/

fabian.freyer_physik.tu-berlin.de updated this revision to Diff 42996.May 25 2018, 4:28 PM

good catch, @tobik!

fabian.freyer_physik.tu-berlin.de marked an inline comment as done.May 25 2018, 4:29 PM
tobik added inline comments.May 25 2018, 4:55 PM
editors/gomate/Makefile
19

Hmm, these should be curly braces, but I'd just use bin/gomate directly.

fabian.freyer_physik.tu-berlin.de updated this revision to Diff 42997.May 25 2018, 4:58 PM
fabian.freyer_physik.tu-berlin.de marked an inline comment as done.
tobik accepted this revision.May 25 2018, 5:00 PM

I'll take care of this over the weekend unless someone beats me to it.

This revision is now accepted and ready to land.May 25 2018, 5:00 PM
fabian.freyer_physik.tu-berlin.de added a comment.May 25 2018, 5:01 PM

nice, thanks!

Closed by commit rP470882: New port: editors/gomate (authored by tobik). · Explain WhyMay 26 2018, 6:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
editors/
gomate/
20 lines
3 lines
5 lines
5 lines

Diff 42997

View Options

editors/gomate/Makefile

Loading...
View Options

editors/gomate/distinfo

Loading...
View Options

editors/gomate/pkg-descr

Loading...
View Options

editors/gomate/pkg-message

Loading...